impact-graph icon indicating copy to clipboard operation
impact-graph copied to clipboard

Adding projects to a round in a simple way from admin bro

Open maryjaf opened this issue 1 year ago • 16 comments

Now for adding a project to a active round the admin user should pass this step

  1. In project page tap on filter
  2. Enter the project title or slug in filter section
  3. Tap on apply change
  4. After showing project , tap on add project to QF round these steps for adding a lot of project take more time and it is so boring

It's better that a simple way should be designed for adding lots of projects to a specific round cc: @laurenluz @mohammadranjbarz

maryjaf avatar Sep 10 '23 13:09 maryjaf

@WhyldWanderer or @maryjaf - do you have a suggestion on how we could improve this?

Do we have backend bandwidth to improve this in the next week before we launch the Optimism QF round? I expect we'll be adding about 100-125 projects in that round. @CarlosQ96 @mohammadranjbarz

laurenluz avatar Sep 27 '23 19:09 laurenluz

Now on the stage with the cooperation of Mohammad, the projects that have a polygon or op address , were added to a specific round with the database Query we can use this solution on production or design a more better flow to add in admin bro that admin users could add many projects to a round

maryjaf avatar Sep 28 '23 10:09 maryjaf

this is really interesting! @CarlosQ96 @mohammadranjbarz - does this mean that we (comms/community) can just give you a list of the projects... and you can make a query to add them to the round? should we do that for the Optimism round?

we are currently keeping track of projects in here (the green ones have met all requirements): https://docs.google.com/spreadsheets/d/128pT6L4cVbZtmFAsUloDG238Xt4c3v7BxJTes5J_Yk0/edit#gid=0

laurenluz avatar Oct 02 '23 21:10 laurenluz

@MoeNick - how come this is in icebox?

laurenluz avatar Oct 02 '23 21:10 laurenluz

this is really interesting! @CarlosQ96 @mohammadranjbarz - does this mean that we (comms/community) can just give you a list of the projects... and you can make a query to add them to the round? should we do that for the Optimism round?

we are currently keeping track of projects in here (the green ones have met all requirements): https://docs.google.com/spreadsheets/d/128pT6L4cVbZtmFAsUloDG238Xt4c3v7BxJTes5J_Yk0/edit#gid=0

Yeah sure, exactly

mohammadranjbarz avatar Oct 04 '23 07:10 mohammadranjbarz

@WhyldWanderer @NikolaCreatrix - can you guys chime in here on how you think that we can improve admin bro to make it easier to add project to the round?

trying to decide if we should prioritize this issue.

laurenluz avatar Jan 23 '24 18:01 laurenluz

@maryjaf do you still think we should work on this issue? do you have ideas on how we should improve admin bro so that it doesn't require a dev to add the projects in bulk?

laurenluz avatar Jan 30 '24 17:01 laurenluz

@maryjaf do you still think we should work on this issue? do you have ideas on how we should improve admin bro so that it doesn't require a dev to add the projects in bulk?

I think the opinion of owner of adding projects to the round could be more useful for this issue Now adding huge number of projects to a round by current admin behavior is very difficult and it is needed to add these project manually from database

I left a comment on the below issue, it seems these two issues are related

https://github.com/Giveth/impact-graph/issues/1029#issuecomment-1918534525

maryjaf avatar Jan 31 '24 07:01 maryjaf

I put p2 to this, correct me @laurenluz if Im wrong.

MoeNick avatar Feb 05 '24 11:02 MoeNick

can you guys chime in here on how you think that we can improve admin bro to make it easier to add project to the round?

I am curious if there is a way to do it via csv? I know we can export csv's from the adminbro.. is it also possible to import a csv list of all the slugs of the projects, or IDs?

WhyldWanderer avatar Feb 12 '24 18:02 WhyldWanderer

Thanks @CarlosQ96 I've tested this issue and now by adding project ids in this new field "Add Project Ids List" in Qf page, the projects are added to the round correctly But when I tap on "edit" button for this qf round, these field are empty although these project ids are added correctly to this round https://impact-graph.serve.giveth.io/admin/resources/QfRound/records/90/edit image.png

maryjaf avatar Apr 18 '24 08:04 maryjaf

@maryjaf yeah the field is just for adding the projects. But not for displaying. Should I add some field to display those ids?

CarlosQ96 avatar Apr 18 '24 13:04 CarlosQ96

Yes lets do it. @maryjaf confirmed we will benefit from showing project IDs

jainkrati avatar Apr 18 '24 13:04 jainkrati

@CarlosQ96 pls guide @Meriem-BM to take this up.

jainkrati avatar Apr 23 '24 09:04 jainkrati

@Meriem-BM I think we can add another virtual field for removing projects using the same logic.

Also @maryjaf wants to know which projects are added. I remember there is a adminBRO / adminJs property called like prefill or like a placeholder. So that the ids are visible in the textArea, or you can make a custom component for that textArea prefilling the ids.

Can fill in the textArea that is for adding new projects to the qfround as there is logic that prevents adding them twice, so its safe.

CarlosQ96 avatar Apr 23 '24 15:04 CarlosQ96

@Meriem-BM pls take this up with guidance from @CarlosQ96

jainkrati avatar May 06 '24 05:05 jainkrati

But when I tap on "edit" button for this qf round, these field are empty although these project ids are added correctly to this round https://impact-graph.serve.giveth.io/admin/resources/QfRound/records/90/edit

Thanks @Meriem-BM this problem has been resolved

  • [ ] I have one suggestion for next improvements on this, if you agree @jainkrati @Meriem-BM we could create a separate issue for next phase Now If an Id is set by user that it isn't in our db and actually this projectId not be correct, this message is shown: "There was an error updating record, Check out console to see more information."

It would be helpful if the incorrect ids be mentioned in the message

maryjaf avatar May 14 '24 12:05 maryjaf

  • [x] I couldn't remove a project by using this new field, please take a look @Meriem-BM -select one Qf round -tap on edit -Remove one or more project ids -tap on save -tap on edit again -the removing ids are also shown

https://github.com/Giveth/impact-graph/assets/111529185/8157b1df-89d1-43ea-8f7a-7e7718e3dc46

maryjaf avatar May 20 '24 17:05 maryjaf

  • [ ] I couldn't remove a project by using this new field, please take a look @Meriem-BM -select one Qf round -tap on edit -Remove one or more project ids -tap on save -tap on edit again -the removing ids are also shown

Screen.Recording.2024-05-20.at.9.13.22.PM.mov

Kindly reminder @Meriem-BM

maryjaf avatar May 27 '24 07:05 maryjaf

  • [ ] I have one suggestion for next improvements on this, if you agree @jainkrati @Meriem-BM we could create a separate issue for next phase Now If an Id is set by user that it isn't in our db and actually this projectId not be correct, this message is shown: "There was an error updating record, Check out console to see more information."

It would be helpful if the incorrect ids be mentioned in the message

What do you think about this ? Do you think it would be helpful for admin user or we can ignore this ? @laurenluz

maryjaf avatar May 27 '24 07:05 maryjaf

Hey @maryjaf, sorry for the delay, you can test this now

Meriem-BM avatar Jun 03 '24 15:06 Meriem-BM

  • I have one suggestion for next improvements on this, if you agree @jainkrati @Meriem-BM we could create a separate issue for next phase Now If an Id is set by user that it isn't in our db and actually this projectId not be correct, this message is shown: "There was an error updating record, Check out console to see more information."

It would be helpful if the incorrect ids be mentioned in the message

What do you think about this ? Do you think it would be helpful for admin user or we can ignore this ? @laurenluz

Hey @maryjaf! I think this is a good suggestion but perhaps not worth the extra work. there are very few people using admin bro, so as long as we know.... like some issue happened and it wasn't added, I Think the admin can trouble shoot and double check the id perhaps.

But I won't say know if it's super easy 😅 just trying to be conscious about our full dev pipeline.

laurenluz avatar Jun 04 '24 23:06 laurenluz

Hey @maryjaf, sorry for the delay, you can test this now

Thanks @Meriem-BM I'v tested again and it has been fixed.

maryjaf avatar Jun 05 '24 13:06 maryjaf