giveth-next
giveth-next copied to clipboard
Support pagination and sort in fetch projects endpoint
-
[ ] For Typescript:
-
[x] Verified
-
[ ] Traceable
-
[x] By Impact
-
[x] Create Date (ascending / descending)
-
[x] Hearts
-
[ ] Amount Raised
-
[ ] For Next-JS:
-
[x] Verified
-
[ ] Traceable
-
[x] By Impact
-
[x] Create Date (ascending / descending)
-
[x] Hearts
-
[x] Amount Raised
Trace sorting, and pagination is matter @CarlosQ96 raised the issue we may keep it simple and pass it right know.
@divine-comedian It's ready for the test but it's better to test it alongside frontend https://github.com/Giveth/giveth-next/issues/319
@divine-comedian It's ready for the test but it's better to test it alongside frontend #319
what would a succesful test look like?
@divine-comedian It's ready for the test but it's better to test it alongside frontend #319
what would a succesful test look like?
I think it's enough to just test https://github.com/Giveth/giveth-next/issues/278, actually they are the same
testing next.giveth.io
I tested sorting projects and load more
while sorting projects in various ways everything worked mostly except when I hit the end of a list of sorted projects the load more button still shows
can this be related to this issue I reported earlier? #572 @mohammadranjbarz
testing
next.giveth.io
I tested sorting projects and
load more
while sorting projects in various ways everything worked mostly except when I hit the end of a list of sorted projects the load more button still showscan this be related to this issue I reported earlier? #572 @mohammadranjbarz
I have checked the graphql queries, and It seems ok,
@mateodaza could you check the frontend?
It might be a wrong statement for showing LOADE MORE
button
testing
next.giveth.io
I tested sorting projects andload more
while sorting projects in various ways everything worked mostly except when I hit the end of a list of sorted projects the load more button still showscan this be related to this issue I reported earlier? #572 @mohammadranjbarz
I have checked the graphql queries, and It seems ok, @mateodaza could you check the frontend? It might be a wrong statement for showing
LOADE MORE
button
They look ok to me!
testing on next.gvieth.io
when I make a query that returns no results I get an appropriate message -
I noticed we lost the Create a Project link in the process - I would make some small tweaks - increasing the font size and weight and the messaging "No projects match your search - Create a project"
when i reach the end of the search results I no longer see the LOAD MORE button