giveth-next icon indicating copy to clipboard operation
giveth-next copied to clipboard

Support pagination and sort in fetch projects endpoint

Open mohammadranjbarz opened this issue 3 years ago • 9 comments

  • [ ] For Typescript:

  • [x] Verified

  • [ ] Traceable

  • [x] By Impact

  • [x] Create Date (ascending / descending)

  • [x] Hearts

  • [ ] Amount Raised


  • [ ] For Next-JS:

  • [x] Verified

  • [ ] Traceable

  • [x] By Impact

  • [x] Create Date (ascending / descending)

  • [x] Hearts

  • [x] Amount Raised

mohammadranjbarz avatar Oct 03 '21 11:10 mohammadranjbarz

Trace sorting, and pagination is matter @CarlosQ96 raised the issue we may keep it simple and pass it right know.

MoeNick avatar Oct 18 '21 15:10 MoeNick

@divine-comedian It's ready for the test but it's better to test it alongside frontend https://github.com/Giveth/giveth-next/issues/319

mohammadranjbarz avatar Nov 07 '21 06:11 mohammadranjbarz

@divine-comedian It's ready for the test but it's better to test it alongside frontend #319

what would a succesful test look like?

divine-comedian avatar Nov 07 '21 16:11 divine-comedian

@divine-comedian It's ready for the test but it's better to test it alongside frontend #319

what would a succesful test look like?

I think it's enough to just test https://github.com/Giveth/giveth-next/issues/278, actually they are the same

mohammadranjbarz avatar Nov 07 '21 16:11 mohammadranjbarz

testing next.giveth.io

I tested sorting projects and load more while sorting projects in various ways everything worked mostly except when I hit the end of a list of sorted projects the load more button still shows image

can this be related to this issue I reported earlier? #572 @mohammadranjbarz

divine-comedian avatar Dec 21 '21 18:12 divine-comedian

testing next.giveth.io

I tested sorting projects and load more while sorting projects in various ways everything worked mostly except when I hit the end of a list of sorted projects the load more button still shows image

can this be related to this issue I reported earlier? #572 @mohammadranjbarz

I have checked the graphql queries, and It seems ok, @mateodaza could you check the frontend? It might be a wrong statement for showing LOADE MORE button

mohammadranjbarz avatar Dec 22 '21 02:12 mohammadranjbarz

testing next.giveth.io I tested sorting projects and load more while sorting projects in various ways everything worked mostly except when I hit the end of a list of sorted projects the load more button still shows image can this be related to this issue I reported earlier? #572 @mohammadranjbarz

I have checked the graphql queries, and It seems ok, @mateodaza could you check the frontend? It might be a wrong statement for showing LOADE MORE button

They look ok to me!

mateodaza avatar Dec 24 '21 12:12 mateodaza

testing on next.gvieth.io

when I make a query that returns no results I get an appropriate message - image

I noticed we lost the Create a Project link in the process - I would make some small tweaks - increasing the font size and weight and the messaging "No projects match your search - Create a project"

divine-comedian avatar Dec 27 '21 13:12 divine-comedian

when i reach the end of the search results I no longer see the LOAD MORE button image

divine-comedian avatar Dec 27 '21 13:12 divine-comedian