giveth-dapp icon indicating copy to clipboard operation
giveth-dapp copied to clipboard

Trying to delegate from a specific donation but not sure why it wont work

Open GriffGreen opened this issue 3 years ago • 21 comments

Screen Shot 2021-08-06 at 7 46 50 PM

I tried delegating to a few traces from this Donation in the my donations page... but then it got stuck

GriffGreen avatar Aug 06 '21 17:08 GriffGreen

as you can see there is a circle spinning there... but I have tried to delegate to 5 different traces but none of them seem to get the money! Screen Shot 2021-08-06 at 8 08 15 PM

Screen Shot 2021-08-06 at 8 08 48 PM

GriffGreen avatar Aug 06 '21 18:08 GriffGreen

https://rinkeby.etherscan.io/tx/0x389ddf985f4809ce276aff21adebf504c96c794f88c01fbf0434d71279957301

Here is one of many transactions i made

GriffGreen avatar Aug 06 '21 18:08 GriffGreen

@mohammadranjbarz would u pls take a look?

MoeNick avatar Aug 06 '21 18:08 MoeNick

@GriffGreen @MoeNick The geth server had problem for sure, Amin updated that, but our problem has not fixed yet, I'm working on it

mohammadranjbarz avatar Aug 06 '21 18:08 mohammadranjbarz

@aminlatifi The simulation deleted Griff's donations ( the weren't mined) and didn't create new donations, I think maybe we have problem somewhere else

Why the payload of Griff's transaction has zero amount, is that right? Screen Shot 1400-05-16 at 12 20 45

mohammadranjbarz avatar Aug 07 '21 07:08 mohammadranjbarz

@aminlatifi The simulation deleted Griff's donations ( the weren't mined) and didn't create new donations, I think maybe we have problem somewhere else

Why the payload of Griff's transaction has zero amount, is that right? Screen Shot 1400-05-16 at 12 20 45

You are right, the tx has not created correctly. @GriffGreen

aminlatifi avatar Aug 07 '21 18:08 aminlatifi

I can't seem to delegate at all to any of these traces... :-( HELP!

GriffGreen avatar Aug 10 '21 17:08 GriffGreen

oh nice! They worked! but this one won't: https://trace.giveth.io/trace/julies-scholarship-for-membership-dues

GriffGreen avatar Aug 10 '21 17:08 GriffGreen

Screen Shot 2021-08-10 at 7 35 37 PM Screen Shot 2021-08-10 at 7 34 17 PM Screen Shot 2021-08-10 at 7 34 07 PM

https://rinkeby.etherscan.io/tx/0x463d89fe0aad9caf6eb95bd049bf3a66f37555a4504f0b463583b13bc324d95b

https://rinkeby.etherscan.io/tx/0x33ec02e1af597c771b37c3b6288279c997937b458210382cd8dfddb6a1084dcb

GriffGreen avatar Aug 10 '21 17:08 GriffGreen

oh nice! They worked! but this one won't: https://trace.giveth.io/trace/julies-scholarship-for-membership-dues Screen Shot 1400-05-19 at 22 21 50

It's committed now

mohammadranjbarz avatar Aug 10 '21 17:08 mohammadranjbarz

Screen Shot 2021-08-10 at 7 35 37 PM Screen Shot 2021-08-10 at 7 34 17 PM Screen Shot 2021-08-10 at 7 34 07 PM

https://rinkeby.etherscan.io/tx/0x463d89fe0aad9caf6eb95bd049bf3a66f37555a4504f0b463583b13bc324d95b

https://rinkeby.etherscan.io/tx/0x33ec02e1af597c771b37c3b6288279c997937b458210382cd8dfddb6a1084dcb

Screen Shot 1400-05-19 at 22 23 42

@GriffGreen @aminlatifi There is transactions with amount 0, I thinks it's a bug in giveth-dapp that send invalid value for amount

mohammadranjbarz avatar Aug 10 '21 17:08 mohammadranjbarz

Screen Shot 2021-08-10 at 7 35 37 PM Screen Shot 2021-08-10 at 7 34 17 PM Screen Shot 2021-08-10 at 7 34 07 PM https://rinkeby.etherscan.io/tx/0x463d89fe0aad9caf6eb95bd049bf3a66f37555a4504f0b463583b13bc324d95b https://rinkeby.etherscan.io/tx/0x33ec02e1af597c771b37c3b6288279c997937b458210382cd8dfddb6a1084dcb
Screen Shot 1400-05-19 at 22 23 42

@GriffGreen @aminlatifi There is transactions with amount 0, I thinks it's a bug in giveth-dapp that send invalid value for amount

Yes, it's right. Delegating from /my-delegations route set invalid amount

aminlatifi avatar Aug 10 '21 18:08 aminlatifi

Is there any context on how we can test this issue?

divine-comedian avatar Aug 12 '21 15:08 divine-comedian

Delegation works fine in dev env, but I dont have any clue how we can reproduce this bug.

MoeNick avatar Aug 12 '21 18:08 MoeNick

Is there any context on how we can test this issue?

You should delegate to a Campaign or Trace from "My delegations" page. Then check whether the amount of the delegation is correct in that Campaign or Trace view page (under donations section).

RamRamez avatar Aug 13 '21 08:08 RamRamez

I delegated from a couple different accounts to some TRACES, it looks like the values showed up properly, however I'm having trouble making a delegation from my community to a campaign - will make a separate issue. image

image

image

My other question here is that why do our delegations move from the delegation list to donation list once they are delegated? This doesn't make sense to me and would make it actually more confusing for users to keep track of their actions.

divine-comedian avatar Aug 13 '21 15:08 divine-comedian

@divine-comedian do you have any idea how we may design its flow?

MoeNick avatar Aug 13 '21 15:08 MoeNick

Why don't we just keep it in the delegations dashboard and add a DELEGATED badge, with the option to archive it from the UI

divine-comedian avatar Aug 13 '21 16:08 divine-comedian

Still having this issue... but maybe it's working?

I was getting all these errors: Screen Shot 2021-08-18 at 5 24 04 AM

Screen Shot 2021-08-18 at 5 24 24 AM Screen Shot 2021-08-18 at 5 25 23 AM Screen Shot 2021-08-18 at 5 24 31 AM

But then it looks like the delegation is happening

The trace has the money Screen Shot 2021-08-18 at 5 30 36 AM

Its being deducted from the Pledge Screen Shot 2021-08-18 at 5 29 20 AM

but then the list of traces still includes the ones i delegated to?

Screen Shot 2021-08-18 at 5 30 10 AM

GriffGreen avatar Aug 18 '21 03:08 GriffGreen

Still having this issue... but maybe it's working?

I was getting all these errors: Screen Shot 2021-08-18 at 5 24 04 AM

Screen Shot 2021-08-18 at 5 24 24 AM Screen Shot 2021-08-18 at 5 25 23 AM Screen Shot 2021-08-18 at 5 24 31 AM

But then it looks like the delegation is happening

The trace has the money Screen Shot 2021-08-18 at 5 30 36 AM

Its being deducted from the Pledge Screen Shot 2021-08-18 at 5 29 20 AM

but then the list of traces still includes the ones i delegated to?

Screen Shot 2021-08-18 at 5 30 10 AM

@aminlatifi Maybe we should tune our parameters in rate limit config

mohammadranjbarz avatar Aug 18 '21 08:08 mohammadranjbarz

Still having this issue... but maybe it's working?

I was getting all these errors: Screen Shot 2021-08-18 at 5 24 04 AM

Screen Shot 2021-08-18 at 5 24 24 AM Screen Shot 2021-08-18 at 5 25 23 AM Screen Shot 2021-08-18 at 5 24 31 AM

But then it looks like the delegation is happening

The trace has the money Screen Shot 2021-08-18 at 5 30 36 AM

Its being deducted from the Pledge Screen Shot 2021-08-18 at 5 29 20 AM

but then the list of traces still includes the ones i delegated to?

Screen Shot 2021-08-18 at 5 30 10 AM

@GriffGreen We increased the rate limit threshold if you get this error again please let us know, to revise the config ( actually we can tune this config just by try and error)

mohammadranjbarz avatar Aug 19 '21 06:08 mohammadranjbarz