Guillaume Giudicelli

Results 438 comments of Guillaume Giudicelli

https://github.com/idaholab/moose/discussions/28066 was just a convergence issue. Ok once my own TFP PR is merged (it will conflict) I ll take over this one to get it past the finishing line....

ok I rebased and added tests. Machine is borked so I cant run them locally, let's see how civet fares. @aikubo I did remove the restriction to p_h variables. If...

@aikubo can I please get some guidance on that test? The pressures in the CSV file are between 1.9 and 2.3e7 but the IC is at 1e6. Should I just...

@joshuahansel for the independent review please

Thank you for the contribution @aikubo ! I m happy TFP can support porous flow needs as well. And this made me understand a lot more the fluid property needs...

So I think the explicit template instantiations is the right lead for most of the errors If you look at the errors, the majority of them come from templates that...

@nmnobre I see you have unrelated commits linking to this issue. If they go to a PR please amend them first :)

imo as long as there are no component ordering issues in creation / setup, then this is enough. If there are, then I had a commit (removed for now) to...

This should be ready for review now. If it's too big I can remove the new multi-species diffusion physics. It's for TMAP but it fits fine in the scalar transport...

We want those to serve as components. The Action part of the name is just to differentiate them for now. I used Component as the suffix as this is what...