Guillaume Giudicelli
Guillaume Giudicelli
so there's these two formatting errors which should be fairly easy to fix ``` ########################################################################## ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234) Merge branch 'tfp_water_vapor'...
let's remove the merge commit. We prefer rebase. You can remove it by: ``` git reset --hard a6a0e70 git fetch upstream git rebase upstream/devel git push origin HEAD:tfp_water_vapor -f ```...
cleaned up the commit history a little. let's see if tests pass
so you forwarded s_from_h_p to Water97, but is it defined there? Is it defined as s_from_p_h by any chance?
the backtrace explains the story: -something in porousflow water calls T_from_p_h - it s not implemented in TFP, so it goes to the implementation in SinglePhaseFP - this implementation uses...
``` template T Water97FluidProperties::s_from_h_p_template(const T & enthalpy, const T & pressure) const { T temperature = T_from_h_p(enthalpy, pressure); return s_from_p_T_template(pressure, temperature); } ``` this would be fine. As long as...
but if T_from_h_p is implemented, T_from_p_h is definitely the faster and easier to implement
> . I think it might make sense to turn on those flags automatically as part of p_h_variables flag in TabulatedFluidProperties. When does this flag get set? By the user?...
Sounds good. I ll check this out next week. Then I will be on travel so I may not be able to help this through. If you mind the delay...
Looks like this flew under my radar post honeymoon. @aikubo do you still need this?