Guillaume Giudicelli

Results 438 comments of Guillaume Giudicelli

Failures unrelated, due to current work moving an item from BISON to Moose

without having checked the code, what I expect is that when you specify nr of 6 for example with a flat to flat for 5.5, the lattice utils is creating...

I suspect you could just work with 6 rings instead of 5.5 and use the flat to flat for 6 rings instead of the 5.5 flat to flat (so a...

Feel free to reduce the PR to just that change and add a test and some comments as to why it s the way it is.

you're right. I drew it and convinced myself nr-1 was enough but it s not you have a fix in there for the 1 pin case. the >1 case should...

This is right so instead of nr * pitch * sqrt(3) = nr * 3 * r we should have (nr * 3 - 1) * r

@dschwen who is a good person to assign to review this?