Guillaume Giudicelli

Results 438 comments of Guillaume Giudicelli

This should roughly pass. I d be happy to get feedback on lowering the footprint of this on the loops code. Maybe add some stringify definitions? I m not sure...

@loganharbour @lindsayad @roystgnr need a volunteer for a coarse first pass

I think I can get a tad more coverage with simple tests. I ll do That concurrently to addressing reviews

Might be worth waiting a bit at this point. I think there s two big tasks left

I messed up a few things in the process (32 tests), but this is closer to where we want to be I think Nesting under nonlinearthread allows me to consolidate...

Should be ready for another round now. The 32 errors were me trying to move the general UOs into their own separate loop instead of joinAndFinalize. I should have known...

> Do you expect this to affect non-debug performance at all? Hopefully not. But I did change up the Jacobian loops so maybe?

@lindsayad going to resolve the suggestions manually because it didnt auto-resolve on merging them. I checked that i didnt miss any though

well that explains the clicking not working thanks!

I have tracked down the app failure to this commit 23c14883d8b6cc27e323fb6ae3c539a40f6276e8 it doesnt make much sense. I ll see if my new debugging tool can help me figure it ^^