`lgtm/blocked` not being removed on review re-request

[silverwind]

See https://github.com/go-gitea/gitea/pull/29191. The bot did not remove the label after re-request which lifted the block. Maybe GitHub has changed something about this API because I recall this did work before.

Correctly, it should have removed lgtm/blocked and added lgtm/need-2.

[yardenshoham]

I think it's because @denykson removed the self-review request. He should try to request a self-review

[denyskon]

@yardenshoham Re-requesting review didn't work, so I tried removing the review request

[yardenshoham]

Hmmm that's weird, you can review the approval logic here

https://github.com/GiteaBot/gitea-backporter/blob/c76b28699e142a4f5903131df223c6cafb80d7d5/src/github.ts#L288-L342

[yardenshoham]

Actually this is working as designed, we don't dismiss blockers on review request. Only on review dismiss. The problem is that we can't detect a self-review request, only that a review from the user is requested. So the algorithm has a flaw, you can't dismiss a blocker if you are a non-merger maintainer.

You could approve then request self-review, that'll do it.