integrations icon indicating copy to clipboard operation
integrations copied to clipboard

Mermaid - Add securityLevel loose to open links in a new tab

Open rodrcastro opened this issue 2 years ago • 5 comments

New links can be opened in a new tab based on the Mermaid documentation. This requires the security level to be set to loose.

This PR adds the security level loose to allow for links to be opened in a new tab.

rodrcastro avatar Oct 03 '23 12:10 rodrcastro

⚠️ No Changeset found

Latest commit: 0c39f66cd7bc176b56e168fb3357075fe51b477c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 03 '23 12:10 changeset-bot[bot]

Hm, it's a bit risky because securityLevel: 'loose' can allow JS callbacks to be executed which makes it prone to XSS attacks. I am not really sure if we should offer it as a default behaviour. @SamyPesse any thoughts?

taranvohra avatar Oct 11 '23 13:10 taranvohra

PR related to issue logged: https://github.com/GitbookIO/integrations/issues/240

addisonschultz avatar Apr 16 '24 16:04 addisonschultz

@rodrcastro checking back on this - is this something that users are still asking about? I'm cleaning up some PRs in this repo

addisonschultz avatar Jul 03 '24 02:07 addisonschultz

@addisonschultz Nope, they didn't come back for this.

rodrcastro avatar Jul 03 '24 08:07 rodrcastro