gitbook icon indicating copy to clipboard operation
gitbook copied to clipboard

Revamp mobile navigation

Open nolannbiron opened this issue 7 months ago • 4 comments

nolannbiron avatar Jun 07 '25 10:06 nolannbiron

🦋 Changeset detected

Latest commit: 88cd02f1d5cb9b9f06633deb10b86ffc5151984d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 07 '25 10:06 changeset-bot[bot]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v2 (Inspect) ⚠️ Changes detected (Review) 16 changed Jul 24, 2025, 4:49 PM
v2-cloudflare (Inspect) ⚠️ Changes detected (Review) 24 changed, 2 added Jul 24, 2025, 4:54 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 21 changed, 2 added Jul 24, 2025, 4:51 PM

argos-ci[bot] avatar Jun 07 '25 10:06 argos-ci[bot]

@SamyPesse Probably not the sexiest approach, but this way we can preserve the initial HTML (desktop TOC) and switch to the Sheet TOC for mobile, so no duplicate

I’m not a big fan of relying on useIsMobile, but given that we’re passing a context props (not serializable) to a lot of components, it’s tricky to implement a clean client-side solution without breaking things

I still think it's a good improvement and it won't change anything on desktop

nolannbiron avatar Jun 09 '25 16:06 nolannbiron