gitbook icon indicating copy to clipboard operation
gitbook copied to clipboard
verified publisher icon GitbookIO

Add German Locale support

Open burghoffdavid opened this issue 1 year ago • 1 comments

Hi, I've added German locale support for GitBook.

Link to Diskussion: https://github.com/orgs/GitbookIO/discussions/537

burghoffdavid avatar May 15 '24 11:05 burghoffdavid

@addisonschultz

burghoffdavid avatar May 15 '24 11:05 burghoffdavid

I just noticed that I did not import the new locale file inside src/intl/translations/index.ts to add it to the languages var. Should this be added with this PR or will it be added further down the line by the team?

burghoffdavid avatar May 27 '24 14:05 burghoffdavid

@burghoffdavid Could you please add the translation import in? Thank you!

addisonschultz avatar May 28 '24 02:05 addisonschultz

@addisonschultz Done :heavy_check_mark:

burghoffdavid avatar May 28 '24 05:05 burghoffdavid

@addisonschultz Not entirely sure why the typecheck CI is failing, any ideas?

burghoffdavid avatar May 28 '24 06:05 burghoffdavid

@burghoffdavid yep - I've got to add these types to our backend schema - working on that now 😄

addisonschultz avatar May 28 '24 10:05 addisonschultz

Hi @burghoffdavid - first off, I want to apologize for the delays on getting this PR up and live so slowly - it's brought to my attention a lot of workflow improvements we need to make on our end in order to make this a lot more smooth.

Secondly, I wanted to let you know that your contribution is now live in GitBook!

Screenshot 2024-06-19 at 19 51 27

You can now update the locale to German - let me know if you have any questions!

addisonschultz avatar Jun 19 '24 10:06 addisonschultz