GitVersion icon indicating copy to clipboard operation
GitVersion copied to clipboard

fix!: no-bump-message now takes precedence over *-version-bump-message.

Open jeanplevesque opened this issue 2 years ago • 1 comments

Description

This PR changes the behavior of commit-message-incrementing when using commits that matches both *-version-bump-message and no-bump-message. no-bump-message now takes precedence over *-version-bump-message.

Previous Behavior

Commits that match both *-version-bump-message and no-bump-message use the highest increment associated with *-version-bump-message.

New Behavior

Commits that match both *-version-bump-message and no-bump-message don't have an increment.

Related Issue

Resolves #3172.

Motivation and Context

Repositories that enforce conventional commits along with commit-message-incrementing (with a config like this) can now have commits that don't have version bumps.

Example:

chore: Adjust .editorconfig for coding convention.
+semver: skip

How Has This Been Tested?

An integration test was added to ensure the new behavior is covered by tests. The newly added test fails when reverting the changes.

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

jeanplevesque avatar Sep 22 '22 00:09 jeanplevesque

Do you feel like this is ready for review now, @jeanplevesque?

Yep! 😀

jeanplevesque avatar Sep 23 '22 22:09 jeanplevesque

Thank you @jeanplevesque for your contribution!

mergify[bot] avatar Sep 26 '22 13:09 mergify[bot]