GitVersion icon indicating copy to clipboard operation
GitVersion copied to clipboard

Rename tag to label

Open asbjornu opened this issue 9 years ago • 5 comments

In GitVersion, a tag is not the same thing as a Git tag, which I find a bit confusing. Wanting to reference a Git tag and use it as the value of the pre-release tag makes it even more confusing. It is currently not possible to do this, but discussions on Gitter might indicate that something like this would be very handy:

branches:
  release:
    tag: useLatestTagLabel

However, it would be easier to understand if we renamed the pre-release tag to label:

branches:
  release:
    label: useFromLatestTag

This would allow for alternating pre-release labels on the same branch, such that a beta could be promoted to rc and stay at rc without having to tag every commit on that branch.

Thoughts?

asbjornu avatar Oct 02 '16 12:10 asbjornu

Maybe just pre-release, that is what semver.org calls it?

We can probably include this change in v4 if we move on it soon. Thoughts @asbjornu

JakeGinnivan avatar Feb 25 '17 14:02 JakeGinnivan

@JakeGinnivan: What SemVer says about this that I can find, is:

Additional labels for pre-release and build metadata are available as extensions to the MAJOR.MINOR.PATCH format.

And:

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version.

So it seems to call these pre-release strings for labels or identifiers. Perhaps pre-release-identifier or pre-release-label could work? I think just label works too, but identifier is too generic.

asbjornu avatar Feb 27 '17 08:02 asbjornu

This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 29 '19 05:06 stale[bot]

If no one objects, I'd like to conclude this discussion with renaming tag to label. PRs welcome. 😃 🙏

asbjornu avatar Mar 19 '20 11:03 asbjornu

If no one objects, I'd like to conclude this discussion with renaming tag to label. PRs welcome.

I like your idea to rename it to label. :)

HHobeck avatar Sep 24 '22 09:09 HHobeck

:tada: This issue has been resolved in version 6.0.0 :tada: The release is available on:

Your GitReleaseManager bot :package::rocket:

arturcic avatar Dec 22 '22 15:12 arturcic