GitReleaseManager icon indicating copy to clipboard operation
GitReleaseManager copied to clipboard

Make unit test conventions consistent

Open gep13 opened this issue 5 years ago • 5 comments

Some unit test have the method format ThisIsATest() and others This_Is_A_Test().

gep13 avatar Aug 25 '20 20:08 gep13

@akordowski @AdmiringWorm I have no real opinion on this either way. Which one would we prefer?

gep13 avatar Aug 25 '20 20:08 gep13

I prefer This_Is_A_Test(). On long method names this is better readable.

akordowski avatar Aug 25 '20 20:08 akordowski

@akordowski this comment isn't related to this issue, is it?

gep13 avatar Aug 25 '20 21:08 gep13

I agree with @akordowski in this. Having underscores in the unit test names make them more readable, but this would require a change in the StyleCop rules (I think).

AdmiringWorm avatar Aug 26 '20 03:08 AdmiringWorm

So, sounds like This_Is_A_Test() is the winner. No objections from me in adopting this.

gep13 avatar Aug 26 '20 18:08 gep13