GitReleaseManager icon indicating copy to clipboard operation
GitReleaseManager copied to clipboard

Published 20 hours ago • verified publisher icon GitTools

(GH-90) Relax restriction of one label per issue

Open robertlyson opened this issue 7 years ago • 11 comments

This PR addresses https://github.com/GitTools/GitReleaseManager/issues/90.

robertlyson avatar Sep 26 '17 17:09 robertlyson

@robertlyson omg it's you again. Love your work.

image

Was about to tweet out a bounty but no need now. Get this merged in and I'll buy you a beer.

ghuntley avatar Oct 05 '17 00:10 ghuntley

Alright gep13 has asked me to review. Busy tonight though - might be a couple days. Thank-you @robertlyson. One less thing to do/thing that was blocking the release of reactiveui/reactiveui v8!

ghuntley avatar Oct 09 '17 08:10 ghuntley

I will chip in on that beer once this gets merged!

RichiCoder1 avatar Oct 12 '17 20:10 RichiCoder1

@gep13 I downloaded the source from AppVeyor. Initial test was good I added issue-labels-many: true to my GitReleaseManager.yml and it created a release not problems! Everything in the release seemed to be in order.

RLittlesII avatar Aug 09 '18 03:08 RLittlesII

@gep13 base on the provided gist that was generated from using this PR's source, my expectations would have been the following.

  • issue-labels-alias should be respected when creating headers and plurals
  • 1702 should have shown under both ReactiveUI Core and Bugs label
  • 1650 should have shown under both Windows Forms and Bugs

Other than those things, I am not sure I had many expectations. Sight unseen (not looking at the issue, or the PR code), these would have been my expectations from this feature. If any of this extends past what the feature is providing, I am honestly just happy to have GRM succeed in generating notes with multiple labels.

RLittlesII avatar Aug 13 '18 14:08 RLittlesII

@gep13 Status Check? How can I help move these chains?

RLittlesII avatar May 15 '19 22:05 RLittlesII

@gep13 I've code reviewed this PR and I think it looks good. Time to merge?

GeertvanHorrik avatar Nov 03 '19 20:11 GeertvanHorrik

@gep13 seems like this was a good idea? need any help reviving it?

SimonCropp avatar Jan 26 '20 01:01 SimonCropp

@SimonCropp said... seems like this was a good idea? need any help reviving it?

I am certainly not going to say no 😄

I have been internally debating this for a while, as I think there is more to it, once we open up the ability to have more than one label, i.e. grouping of issues/pr's into section based on a label, ordering issues/pr's based on another label, and I have never settled on a "good" way to handle all these things.

Perhaps I have been over-complicating the issue, and "all" that is required is support for having multiple labels, and having an issue/pr appear in two sections of the generated release notes.

Would be happy for you to take a spin at implementing this. There has been a lot of work done on the code base since this PR was raised, so could be that it would be better to start again.

gep13 avatar Jan 28 '20 07:01 gep13

I would love for something like @gep13 mentions be implemented:

"all" that is required is support for having multiple labels, and having an issue/pr appear in two sections of the generated release notes

At least that would be a very good start. Then we could think about improving that functionality.

Cheesebaron avatar Jan 30 '20 14:01 Cheesebaron