GitLink icon indicating copy to clipboard operation
GitLink copied to clipboard

Argument.IsNotNullOrEmpty(nameof(path), path) thrown

Open etalon opened this issue 6 years ago • 4 comments

The GetNormalizedPath-Function is called with an empty path. I don't know why an empty path is passed an not filtered.

I tried removing empty paths in Linker.Link-Function and then it worked but I don't want to push this.

I call GitLink.exe with the following arguments: $arguments = $pathToPdb + " --baseDir " + $workingDir + " --url " + $url

PS: A new release would be fine. Thanks for your efforts.

etalon avatar Jan 11 '19 14:01 etalon

Interested in doing a PR?

GeertvanHorrik avatar Jan 13 '19 13:01 GeertvanHorrik

Sorry, what is a PR?

etalon avatar Jan 19 '19 13:01 etalon

PR stands for Pull Request.

GeertvanHorrik avatar Jan 19 '19 15:01 GeertvanHorrik

Thanks, sure. My changes in the code are working, but I didn't solve the problem from the root. So I don't want to push this. Someone who knows the code in detail can say where these empty paths come from.

etalon avatar Feb 01 '19 10:02 etalon