GitLink icon indicating copy to clipboard operation
GitLink copied to clipboard

Submodule support

Open reupen opened this issue 6 years ago • 0 comments

Hi,

I ran GitLink 3.2.0-unstable0040 (from Chocolatey) on one of my C++ projects (which uses Git submodules):

gitlink -a .\Release\foo_ui_columns.pdb

It resulted in a lot of messages such as the following being printed:

Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\base.h".
Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\buttons.h".
Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\columns_ui.cpp".
Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\columns_ui.h".
Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\columns_ui_appearance.h".
Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\container_window_v2.h".
Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\helpers.h".
Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\imp_helper.h".
Found a file where we expected to find a directory: "F:\foobar2000\columns_ui\columns_ui-sdk\menu.h".

The paths are all within submodules so I assume the messages are related to that.

It would be great to add full support for submodules, though making it less worse (e.g. ignoring submodules) would still be an improvement.

Steps to reproduce

In a VS 2017 command prompt:

git clone --recursive https://github.com/reupen/columns_ui.git
cd columns_ui
msbuild /m /p:Platform=Win32 /p:Configuration=Release /t:Rebuild vc15\columns_ui-public.sln
gitlink -a .\vc15\Release\foo_ui_columns.pdb

Expected behaviour

No errors.

Actual behaviour

Errors as above.

reupen avatar Jul 04 '18 19:07 reupen