edex-ui icon indicating copy to clipboard operation
edex-ui copied to clipboard

UI reload crash when using multiple tabs

Open clragon opened this issue 4 years ago • 6 comments

Technical information

Using version:

  • master (running from GitHub-published source code, currently v3.0.0-pre)

Running on:

  • Windows

How comfortable you are with your system and/or IT in general:

  • My machine is fully under my control, tell me what you need

Problem

Reloading the app and opening a previously open terminal tab leads to a crash.

12774246

clragon avatar Nov 10 '19 14:11 clragon

Tabs state isn't saved between window reloads, which causes this. Perhaps the main process could forward a list of open sockets via IPC? Will look into this

GitSquared avatar Nov 10 '19 16:11 GitSquared

Might have already fixed this in #892

Animus-Surge avatar Nov 27 '20 17:11 Animus-Surge

Indeed, it doesn't crash anymore... The state is still not saved between UI reloads though, so I think we can keep this open.

Unlikely to ever be fixed before a rewrite, to be honest.

GitSquared avatar Nov 27 '20 17:11 GitSquared

The state is still not saved between UI reloads

Can look into that if you want. Doesn’t seem like it should be too hard (famous last words)

Animus-Surge avatar Nov 27 '20 17:11 Animus-Surge

haha, sure, feel free to try it.

GitSquared avatar Nov 28 '20 15:11 GitSquared

Mailbox

ghost avatar May 22 '21 09:05 ghost