firebase-kotlin-sdk icon indicating copy to clipboard operation
firebase-kotlin-sdk copied to clipboard

Firestore: Insufficient documentation.

Open Monabr opened this issue 1 year ago • 4 comments
trafficstars

Hi.

There is not enough documentation for Firestore. Even in KDoc there are almost no comments on functions explaining what each function or argument does, and what the function's result is.

Please cover all functionality with documentation.

Monabr avatar Sep 05 '24 21:09 Monabr

The general rule of thumb is to map it closely the Android sdk, you can see the google docs here:

https://firebase.google.com/docs/reference/kotlin/packages

Remember this library is just a wrapper of the current implementation, we are not re-inventing the wheel, just trying to unify things.

Reedyuk avatar Sep 09 '24 09:09 Reedyuk

@Reedyuk I understand that. But still some functions and parameters changed. If it is 1 to 1 implementation - comments could be just copied from the source. I believe a user of the library should be able to see the documentation directly on the the functionality and not spend additional time to search it separately.

Monabr avatar Sep 09 '24 09:09 Monabr

Happy for you to open a PR and we can review it.

Reedyuk avatar Sep 09 '24 09:09 Reedyuk

The current documentation was kindly contributed by @BasBuijsen here https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/537

Definitely agree the relevant documentation should just be copied from the android documentation but as mentioned in the PR its a large piece of work that has yet to be contributed.

nbransby avatar Sep 12 '24 03:09 nbransby