firebase-kotlin-sdk icon indicating copy to clipboard operation
firebase-kotlin-sdk copied to clipboard

OAuthProvider android property is unaccessible in 2.0.0

Open mr-kew opened this issue 1 year ago • 5 comments
trafficstars

I can't access android property of OAuthProvider anymore, guess the #504 did break it.

import dev.gitlive.firebase.auth.OAuthProvider
import dev.gitlive.firebase.auth.android // Greyed out

fun test(provider: OAuthProvider) {
    val androidProvider = provider.android // Error: Cannot access 'android': it is internal in 'OAuthProvider'
}

mr-kew avatar Aug 28 '24 15:08 mr-kew

@Reedyuk did we miss this one?

nbransby avatar Aug 28 '24 15:08 nbransby

wtf-monkey

Reedyuk avatar Aug 28 '24 15:08 Reedyuk

Looks to be here: https://github.com/GitLiveApp/firebase-kotlin-sdk/blob/650ff89e15e5dae28afde4c22c65721374a5bb3c/firebase-auth/src/androidMain/kotlin/dev/gitlive/firebase/auth/credentials.kt#L55

Reedyuk avatar Aug 28 '24 15:08 Reedyuk

I wonder if the import is not right?

import dev.gitlive.firebase.auth.OAuthProvider.android

Reedyuk avatar Aug 28 '24 15:08 Reedyuk

I wonder if the import is not right?

import dev.gitlive.firebase.auth.OAuthProvider.android

It just says directly on the import:

Cannot import 'android', functions and properties can be imported only from packages or object

mr-kew avatar Aug 28 '24 15:08 mr-kew

@Reedyuk The intellisense also seems to see it, but the import does not work for some reason. It almost feels like some kind of compiler bug image

mr-kew avatar Aug 28 '24 16:08 mr-kew

I'm working on a fix for you

Reedyuk avatar Aug 29 '24 05:08 Reedyuk

https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/603

Reedyuk avatar Aug 29 '24 07:08 Reedyuk

its in version 2.1.0

Reedyuk avatar Sep 02 '24 15:09 Reedyuk

Thank you, I am already using 2.1.0 and it works like a charm

mr-kew avatar Sep 03 '24 08:09 mr-kew