firebase-kotlin-sdk
firebase-kotlin-sdk copied to clipboard
Crashlytics - iOS - setCustomKey - wrong parameters order
Hello!
I started using setCustomKey in the Crashlytics library. Unfortunately, the current implementation has some serious issue: the order of parameters in setCustomKey is wrong.
Here is the code from my app:
.distinctUntilChanged()
.onEach { balance ->
logger.i("Setting balance in Crashlytics: $balance")
Firebase.crashlytics.setCustomKey("balance", balance)
}
Here is the result in Crashlytics report:
Here is the Firebase documentation:
It seems like the current implementation was done wrong because of the difference between Android (key, value) and iOS (value, key) Firebase libraries.
Sounds like you know how to fix it! Any chance of a PR?
@nbransby Hah, I'll take a look
Noticed the same issue. Here is the fix PR: https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/646