firebase-kotlin-sdk icon indicating copy to clipboard operation
firebase-kotlin-sdk copied to clipboard

Prerelease

Open corrado4eyes opened this issue 4 years ago • 5 comments
trafficstars

Contains enhancement for encoder/decoder and timestamps

corrado4eyes avatar Jan 20 '21 12:01 corrado4eyes

any idea why the tests are failing?

nbransby avatar Jan 26 '21 22:01 nbransby

can you split this PR into separate PRs for each module? that will make it a lot easier to review and approve

nbransby avatar Jan 26 '21 22:01 nbransby

Hi @nbransby, no not really. The same is happening on the branch for the remote-config implementation.

any idea why the tests are failing?

I'll see what I can do.

can you split this PR into separate PRs for each module? that will make it a lot easier to review and approve

corrado4eyes avatar Jan 27 '21 06:01 corrado4eyes

any idea why the tests are failing?

Here is incorrect import (but it's not a changes from this PR)

https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/140/files#diff-e7d5fd2efb5995b5bf3ab9bfc4efb9bde5a07edb5b5a88609200da9bea6a2e61R13

Same if you run locally:

e: /Users/runner/work/firebase-kotlin-sdk/firebase-kotlin-sdk/firebase-firestore/src/androidMain/kotlin/dev/gitlive/firebase/firestore/firestore.kt: (13, 39): Unresolved reference: encode
> Task :firebase-firestore:compileDebugKotlinAndroid FAILED

@corrado4eyes can you please remove this line in favour of line above (import dev.gitlive.firebase.*)

avdyushin avatar Jan 29 '21 11:01 avdyushin

@nbransby the build is failing on testEncodeDecodeGenericClass and locally the error is

Could not determine the dependencies of task ':firebase-common:jsTestPackageJson'.
> NPM Dependencies already resolved and installed

Do you know how to solve this? (I found this)

corrado4eyes avatar Jan 29 '21 15:01 corrado4eyes

Please rebase and resolve conflicts before can consider reviewing

Reedyuk avatar Apr 05 '23 18:04 Reedyuk