MessageViewController
MessageViewController copied to clipboard
Carthage support
Initially when trying to use Carthage there would be a build error. Carthage was trying to build the MessageViewController
scheme in the example workspace.
This PR removes the example workspace, so to run the example project now you will have to run pod install
prior. Carthage has no way, yet, to ignore specific schemes. All of the example CocoaPod specific files were added to the gitignore as well. Also I lowered the target to iOS 10. I can put it lower if you would like.
Also fixes a bug in the example project. inset
was renamed to textViewInset
Let me know if you would like anything changed!
@wickwirew I’d prefer to leave the examples alone so that someone can just download and run the sample vs having to run install scripts. Would you mind restoring those?
Sent with GitHawk
@rnystrom Sorry should elaborated more but having the Example workspace is what’s causing the issue. When Carthage looks for the MessageViewController
scheme to build it’s taking the one in the Example.xcworkspace
, not the MessageViewController.xcodeproj
. Which is causing build errors due to a source file missing from it if I remember correctly. If there’s another solution I’m totally open to it though!
Sent with GitHawk
Carthage will build all shared schemes in a repository. A MessageViewController
scheme exists in both the CocoaPod generated workspace and the standard project. Workspaces always take precedence over projects so it will build the Example workspace one instead. Which is fine, but a new source file was added with out running pod install on the Example project, so it is not included in the target which is causing build errors.
But I suggest giving Carthage a try! Started using it a few months ago and have been very happy with how its working out.
Just a thought, but we can get the desired behavior of not having to run pod install
for the Example project if we create the Example.xcworkspace
ourselves and include the MessageViewController.xcodeproj
manually instead of using CocoaPods to do it for us. Carthage will still build the project from the Example workspace but we won't run into the issue of the Scheme getting out of sync with the original project. Let me know if you like this solution and I can go ahead and add it!