GitHawk icon indicating copy to clipboard operation
GitHawk copied to clipboard

Dis/Approve pull requests

Open moimikey opened this issue 6 years ago • 12 comments

would be nice to be able to also approve or disapprove prs. I can do everything except for that.

Bug Report Dump (Auto-generated)
Version 1.22.0 (1534395229)
Device: iPhone X (iOS 11.4.1)
TestFlight: false

moimikey avatar Aug 22 '18 14:08 moimikey

Aaaaaaabsolutely. The next update I want to get these local pushes working, then focus on a PR-rich update.

Sent with GitHawk

rnystrom avatar Sep 13 '18 16:09 rnystrom

@rnystrom I will have some time to jump on that. I recenlty changed my github workflow to 100no emails :)

flovilmart avatar Jan 30 '19 01:01 flovilmart

yey

moimikey avatar Jan 31 '19 16:01 moimikey

@rnystrom did you have anything in mind for the positioning of such actions?

I am futzing with multiple options:

  • From the menu (with labels and milestones) add Approve / Reject
  • From the menu add 'Add Review' which pushes a new controller with a textView + MergeButton (customized)
  • From the files list

etc...

flovilmart avatar Jan 31 '19 16:01 flovilmart

What is the status of this feature? If I can weight in on the location, it would be really cool to be able to see the “Add review” button in place of the “Not authorized to merge” when there is a missing but required review. Additionally I think it would be natural to add this to the files view to keep it consistent with github’s process.

peterdemartini avatar Jul 01 '19 13:07 peterdemartini

I barely I started with playing with the code. The task is quite daunting when you consider all the cases. I’ll hopefully have time to look at it soon

Sent with GitHawk

flovilmart avatar Jul 01 '19 14:07 flovilmart

Woah! This would be awesome 👏

Sent with GitHawk

Huddie avatar Jul 11 '19 03:07 Huddie

is this feature request still planned?

jonsch avatar Oct 27 '19 06:10 jonsch

Approving a PR was the first task I needed to do when downloading and opening githawk a few minutes ago. Looks like a great app, but the lack of the ability to do PR review has me downloading another app.

leecalcote avatar Jan 09 '20 13:01 leecalcote

@leecalcote also given I requested it in 2018 and we're in 2020 now. :(

moimikey avatar Jan 13 '20 21:01 moimikey

Bump, as a open source project maintainer this feature is greatly needed

sfdye avatar Mar 06 '20 11:03 sfdye

I won’t have time to work on this, unassigning myself

flovilmart avatar Mar 17 '20 02:03 flovilmart