ContextMenu Update to Swift 4.2 and iOS 12

Update to Swift 4.2 and iOS 12

Open LambdaDigamma opened this issue 5 years ago • 5 comments

Carthage Build for iOS 12 project fails with exit code 65. This usually indicates that project itself failed to compile.

./ContextMenu/ContextMenuPresentationController.swift:56:30: error: value of type 'CGRect' has no member 'dominantCorner'

Sep 23 '18 09:09 LambdaDigamma

I encounter same issue, please help to update for that, thanks!

Sep 25 '18 16:09 yonlau

Hello @rnystrom Will you give support for iOS 12 and swift 4.2?

Use the latest version and build the code, drag the ContextMenu into to project manually solve my problem!

Oct 03 '18 14:10 yonlau

Merged #37 for 4.2 support. I don't use Carthage, so not sure what's going on there.

FYI this project is open source, don't have to wait on me for a fix 😉

Oct 17 '18 14:10 rnystrom

#41 should fix Swift 4.2 support for Carthage checkouts.

Oct 28 '18 09:10 sbarow