py-gitguardian icon indicating copy to clipboard operation
py-gitguardian copied to clipboard

WIP: Add support for Secret Incidents API endpoints

Open irgeek opened this issue 1 year ago • 2 comments

The PR adds models and methods to handle the Secret Incidents API endpoints. It still needs a changelog entry and (probably) some cleanup, but I wanted to get some feedback before I put too much work into it. As requested I've sliced the changes up in to several commits for ease of review.

irgeek avatar Dec 29 '23 16:12 irgeek

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (7cf0356) 92.28% compared to head (640ad48) 93.29%.

Files Patch % Lines
pygitguardian/client.py 84.50% 11 Missing :warning:
pygitguardian/utils/response.py 96.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   92.28%   93.29%   +1.01%     
==========================================
  Files           6       11       +5     
  Lines         622      895     +273     
==========================================
+ Hits          574      835     +261     
- Misses         48       60      +12     
Flag Coverage Δ
unittests 93.29% <95.78%> (+1.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Dec 29 '23 16:12 codecov-commenter

The lint check is failing because ggshield complains about the API key.

irgeek avatar Dec 29 '23 16:12 irgeek