ggshield icon indicating copy to clipboard operation
ggshield copied to clipboard

chore: pass secret config around instead of discrete args

Open gg-mmill opened this issue 1 year ago • 1 comments

What has been done

Refactor how secret scan parameters are passed around: pass the SecretConfig around, instead of discrete args (both to the scanner, and in output handlers).

Validation

There should be no functional change.

gg-mmill avatar Oct 14 '24 12:10 gg-mmill

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.58%. Comparing base (56f53ee) to head (d4af106). Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   91.49%   91.58%   +0.08%     
==========================================
  Files         180      180              
  Lines        7597     7605       +8     
==========================================
+ Hits         6951     6965      +14     
+ Misses        646      640       -6     
Flag Coverage Δ
unittests 91.58% <100.00%> (+0.08%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 14 '24 12:10 codecov[bot]