ggshield icon indicating copy to clipboard operation
ggshield copied to clipboard

fix(sarif): Use level variable for detector status handling Fix for …

Open kl2400033266 opened this issue 1 month ago • 0 comments

…issue #1122: Implement support for setting SARIF report level based on detector enabled/disabled status. This commit adds a level variable that can be computed based on whether the detector is enabled or disabled from the platform configuration. Currently defaults to "error" for all detectors, but provides the framework for checking detector status and setting level to "note" for disabled detectors as proposed in issue #1122. Changes: - Added level variable computation in _create_sarif_result_dict() - Updated SARIF result to use dynamic level variable instead of hardcoded "error" - Added TODO comment for implementing platform detector status check

Added logic to determine level based on detector status and included a TODO for future enhancements.

Context

What has been done

Validation

PR check list

  • [ ] As much as possible, the changes include tests (unit and/or functional)
  • [ ] If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

kl2400033266 avatar Nov 27 '25 06:11 kl2400033266