ggshield icon indicating copy to clipboard operation
ggshield copied to clipboard
verified publisher icon GitGuardian

feat: use OS port selection for OAuth server

Open saikumarvasa100-hash opened this issue 1 month ago • 1 comments

Description

Implements OS-based port selection for the local OAuth server as requested in #913.

Changes

  • Modified _prepare_server() to use port 0 for automatic OS port assignment
  • Removed USABLE_PORT_RANGE constant (no longer needed)
  • Simplified error handling

Benefits

  • Cleaner, more maintainable code
  • More reliable port selection
  • Faster server initialization (no loop iteration)

Fixes #913

saikumarvasa100-hash avatar Nov 13 '25 09:11 saikumarvasa100-hash

Hi @saikumarvasa100-hash, thanks for your PR. Unfortunately, the tests are failing. Can you look into this?

agateau-gg avatar Nov 13 '25 10:11 agateau-gg

Closing this as we didn't get feedback from @saikumarvasa100-hash

sevbch avatar Dec 18 '25 09:12 sevbch