APISecurityBestPractices icon indicating copy to clipboard operation
APISecurityBestPractices copied to clipboard

False Positive, and the Email link doesn't work

Open jaakidup opened this issue 5 years ago • 6 comments

There was just a false positive on one of my repos, where a Google APIKey is in the javascript. I tried clicking the false positive button on the email, but that didn't work... Google apiskeys embedded in javascript front-ends are available for the public to see in any-case as the JavaScript is run client side. :)

jaakidup avatar Mar 07 '19 12:03 jaakidup

Thanks for your feedback :). we will definitely look into it for the link for the false positive button.

For the secret detection part we are working on excluding Google API keys that are designed to be exposed publicly.

ericfourrier avatar Mar 13 '19 14:03 ericfourrier

Should be fixed right now thanks, closing the issue

ericfourrier avatar Mar 15 '19 07:03 ericfourrier

@ericfourrier should both issues be fixed or just the button? I've also received a false positive for an OAuth 2.0 Client "Secret" (not sure if those are in some way different from other Google API keys) in an open source Java application just about 25 minutes ago.

Johni0702 avatar Mar 15 '19 17:03 Johni0702

I also had this false positive. My API key is for javascript front end connected to firebase, which is intended to be public.

NoahRoseLedesma avatar Apr 05 '19 19:04 NoahRoseLedesma

Just got another false positive.

For your reference this is what the Firebase console tells you to put in your web-apps:


<script src="https://www.gstatic.com/firebasejs/5.10.0/firebase.js"></script>
<script>
  // Initialize Firebase
  var config = {
    apiKey: "AIzaSyCmE__wXbMOsoM4_xey2a__Ikc589_jWCg",
    authDomain: "ollyg-game-deals.firebaseapp.com",
    databaseURL: "https://ollyg-game-deals.firebaseio.com",
    projectId: "ollyg-game-deals",
    storageBucket: "ollyg-game-deals.appspot.com",
    messagingSenderId: "887268788986"
  };
  firebase.initializeApp(config);
</script>

Noah-Huppert avatar Apr 23 '19 03:04 Noah-Huppert

I am still getting the false positive notification about allegedly exposed API keys, it's not critical though but necessary when using google firebase.

nikita-fuchs avatar Mar 30 '20 12:03 nikita-fuchs