giskard icon indicating copy to clipboard operation
giskard copied to clipboard

added llm_base_url to llm.client.__init__.py

Open osok opened this issue 1 week ago • 2 comments

Description

Related Issue

Type of Change

  • [ ] 📚 Examples / docs / tutorials / dependencies update
  • [ X] 🔧 Bug fix (non-breaking change which fixes an issue)
  • [ ] 🥂 Improvement (non-breaking change which improves an existing feature)
  • [ ] 🚀 New feature (non-breaking change which adds functionality)
  • [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] 🔐 Security fix

Checklist

  • [X ] I've read the CODE_OF_CONDUCT.md document.
  • [ X] I've read the CONTRIBUTING.md guide.
  • [ ] I've written tests for all new methods and classes that I created.
  • [ ] I've written the docstring in Google format for all the methods and classes that I used.
  • [ ] I've updated the pdm.lock running pdm update-lock (only applicable when pyproject.toml has been modified)

I'm new to contributing. I didnt write test cases, I"m not sure how to. The change is like ~10 lines of code. I do realize even one line of code can break a release. I sorted out the fix for the problem I was having and at least wanted to provide something to make things easier.

If there is a resource for how to properly work on python projects like this and build test cases, I'm eager to review it. I'm used to Java projects from like 15 years ago when I did a lot more team development.

osok avatar Jun 21 '24 17:06 osok