giskard
giskard copied to clipboard
Update evaluate.py
Description
Related Issue
Type of Change
- [ ] 📚 Examples / docs / tutorials / dependencies update
- [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
- [ ] 🥂 Improvement (non-breaking change which improves an existing feature)
- [ ] 🚀 New feature (non-breaking change which adds functionality)
- [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
- [ ] 🔐 Security fix
Checklist
- [ ] I've read the
CODE_OF_CONDUCT.md
document. - [ ] I've read the
CONTRIBUTING.md
guide. - [ ] I've written tests for all new methods and classes that I created.
- [ ] I've written the docstring in Google format for all the methods and classes that I used.
- [ ] I've updated the
pdm.lock
runningpdm update-lock
(only applicable whenpyproject.toml
has been modified)
🔍 Existing Issues For Review
Your pull request is modifying functions with the following pre-existing issues:
📄 File: giskard/rag/evaluate.py
Function | Unhandled Issue |
---|---|
evaluate |
LLMGenerationError: Error while evaluating the agent main in <mod... Event Count: 4 |
evaluate |
NameError: name 'domain' is not defined src.modul... Event Count: 2 |
evaluate |
NameError: name 'doc_chat' is not defined _main... Event Count: 1 |
evaluate |
NameError: name 'domain' is not defined main ... Event Count: 1 |
Did you find this useful? React with a 👍 or 👎
Hello @natedem30
Thanks for the contribution. It look like the goal if the PR is to refactor the code. Would it be possible from you to update the PR tittle and description? Thanks!