giskard icon indicating copy to clipboard operation
giskard copied to clipboard

Add compatibility for python 3.12

Open Hartorn opened this issue 1 year ago • 6 comments

Description

Related Issue

Type of Change

  • [ ] 📚 Examples / docs / tutorials / dependencies update
  • [ ] 🔧 Bug fix (non-breaking change which fixes an issue)
  • [ ] 🥂 Improvement (non-breaking change which improves an existing feature)
  • [ ] 🚀 New feature (non-breaking change which adds functionality)
  • [ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] 🔐 Security fix

Checklist

  • [ ] I've read the CODE_OF_CONDUCT.md document.
  • [ ] I've read the CONTRIBUTING.md guide.
  • [ ] I've updated the code style using make codestyle.
  • [ ] I've written tests for all new methods and classes that I created.
  • [ ] I've written the docstring in Google format for all the methods and classes that I used.

Hartorn avatar Nov 23 '23 11:11 Hartorn

@Hartorn this seems to work great with vanilla giskard, but not when we use the optional group llm

mattbit avatar Nov 23 '23 12:11 mattbit

@Hartorn this seems to work great with vanilla giskard, but not when we use the optional group llm

I'm looking at it, but I think torch stable is not yet supporting 3.12, so bert score wont be working. Trying to switch on nightly from torch

Hartorn avatar Nov 23 '23 12:11 Hartorn

Also, https://github.com/pytorch/text pytorch-text depends on specific torch version 2.1.1 Will not work for python 3.12 I think

Hartorn avatar Nov 23 '23 13:11 Hartorn

should be arriving soon on stable : https://github.com/pytorch/pytorch/issues/110436

Hartorn avatar Nov 23 '23 13:11 Hartorn

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Nov 23 '23 14:11 sonarqubecloud[bot]

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 13 '24 03:06 sonarqubecloud[bot]