winter-of-contributing icon indicating copy to clipboard operation
winter-of-contributing copied to clipboard

Iam sakshi patch 1

Open iam-sakshi opened this issue 4 years ago • 9 comments


Description 📜

Solve problem Reverse Word in string with different approaches.

Reverse Word in string #8512


Type of change 📝

  • [ ] Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
  • [ ] Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
  • [x] Doc#umentation (Content Creation in the form of codes or tutorials)
  • [ ] Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

  • [ ] Android Dev #(Flutter)
  • [ ] Android Dev #(Java)
  • [ ] Android Dev #(Kotlin)
  • [ ] Backend Dev #(Java)
  • [ ] Backend Dev #(.NET)
  • [ ] Backend Dev #(PHP)
  • [ ] Backend Dev #(Python)
  • [ ] C/#CPP
  • [x] Competitive #Programming
  • [ ] Cyber #Security
  • [ ] DS#A
  • [ ] Data#base
  • [ ] Datascience with #Python
  • [ ] Datascience with #R
  • [ ] Frontend Dev #HTML/CSS/JS
  • [ ] Frontend Dev #React/Angular/Vue
  • [ ] Go#lang
  • [ ] Interview #Prep
  • [ ] Java_#Domain
  • [ ] JavaScript_#Domain
  • [ ] ME#RN
  • [ ] Machine #Learning
  • [ ] Open #Source
  • [ ] Python_#Domain
  • [ ] Ru#st
  • [ ] Statis#tics
  • [ ] UI/#UX

Checklist ✅

  • [x] I follow Contributing Guidelines & Code of conduct of this project.
  • [x] I have performed a self-review of my own code or work.
  • [x] I have commented my code, particularly in hard-to-understand areas.
  • [x] My changes generates no new warnings.
  • [x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸


iam-sakshi avatar Nov 26 '21 15:11 iam-sakshi

@ravireddy07 please check, I have tried updating the branch but still all the commits are visible , please review the content .

iam-sakshi avatar Nov 26 '21 15:11 iam-sakshi

Which branch you're updating...? @iam-sakshi

ravireddy07 avatar Nov 27 '21 07:11 ravireddy07

I have tried updating all the branches @ravireddy07

iam-sakshi avatar Nov 27 '21 08:11 iam-sakshi

I have updated , please review it now @ravireddy07

iam-sakshi avatar Nov 27 '21 08:11 iam-sakshi

please review now , There is only one file changed , you can check now. @ravireddy07

iam-sakshi avatar Nov 27 '21 08:11 iam-sakshi

please review now , There is only one file changed , you can check now. @ravireddy07

The point here is not to have the commits which already merged. Just update your branch with current CP branch. That will solve.

Just checkout to cp and pull upstream changes and checkout to iam-sakshi-patch-1 and merge it.

ravireddy07 avatar Nov 27 '21 09:11 ravireddy07

Please follow this steps: @iam-sakshi

  1. fork the original repo.
  2. clone your fork in your local.
  3. add upstream/reference to original-repo.
  4. switch to your domain-branch from main.
  5. create a new branch on your domain-branch like contribution-1
  6. start working on issues, add and commit your changes.
  7. now, to resolve or get rid of conflicts: switch to your domain-branch and pull the latest code of your domain-branch.
  8. after pulling, switch to your branch contribution-1 and run git merge domain-branch
  9. If there are any conflicts, resolve them and commit.
  10. now push your changes to contribution-1 branch and make a PR pointing to your domain-branch.

ravireddy07 avatar Nov 27 '21 09:11 ravireddy07

@ravireddy07 is this a valid PR?

gauravdas014 avatar Dec 02 '21 09:12 gauravdas014

Yes @gauravdas014, It's valid.

ravireddy07 avatar Dec 02 '21 10:12 ravireddy07