PythonBeginners icon indicating copy to clipboard operation
PythonBeginners copied to clipboard

add SpeedTest

Open rubalsxngh opened this issue 1 year ago • 2 comments

This pull request addresses the Advanced Task to create GUI based SpeedTest, outlined in Issue Number: #50

Task Accomplished:

  • [X] Implemented a simple visual interface using the tkinter library under scripts/speedtest
  • [X] Displayed the download, upload speeds and Ping in a GUI window.
  • [X] Included a button to trigger the speed test.
  • [ ] Organize the functionality into a class named SpeedTester.
  • [ ] The class should encapsulate the speed test logic and GUI components.
  • [ ] Instantiate the class and run the GUI application.

@IQExotic, could you please review these changes and provide your feedback? Thank you!

rubalsxngh avatar Jan 11 '24 17:01 rubalsxngh

Hello @IQExotic , thanks for the feedback.

I've implemented the suggested changes and completed the tasks as discussed:

  • [X] Resolved redundant code and set button states appropriately.
  • [X] Added comprehensive error handling for potential SpeedTest and image loading issues.
  • [X] Enhanced UI feedback to provide a more responsive indication of the SpeedTest process.
  • [X] Updated comments on resize image function for better clarity and understanding.

Please take a moment to review, if everything aligns with your expectations.

rubalsxngh avatar Jan 11 '24 19:01 rubalsxngh

@IQExotic , Thanks for the review. I'll add an alternative option to launch, if the image not found. Moreover, I am open to receiving additional instructions for the project.

rubalsxngh avatar Jan 12 '24 09:01 rubalsxngh