Gilad Naaman
Gilad Naaman
While looking into this I also found out that `ignore`'s `*` doesn't descend into subdirs, but `*.*` does. I apologize, but I'm not sure that I will have time to...
Hey guys, Also tagging @mitsuhiko and @keats , because your crates depend on globwalk. (and @killercup , which triggered this crate years ago) Sorry for taking such long time to...
Also note that since I'm not doing anything fancy with the pattern itself, all kinds of exotic patterns are not supported as well: ``` ➜ globwalk git:(master) ✗ tree a...
Still not sure what behaviour I want. I lean towards having the default non recursive (like you'd expect). I think the best course of action will be to stop using...
@robinfriedli thank you for working on it! I'll set a reminder to tix this in the upcoming days
After a brief check, it sadly doesn't work exactly like that, and filters out correct files. After applying the patch, the following tests fail after not finding any files: ```...
We can construct a second glob for dirs that contains the prefixes of the original positive patterns. Not sure this cover all cases; especially WRT to `**`, but it's a...
Gladly. I'll try to attack it with tests over the weekend to see if we missed something. Thanks again!
Overall looks good. Note that thos *does* break patterns that have a slash inside an or-group: ``` a/{b/c,b/g}/*.gif ``` Not 100% sure what's the right solution, probably to normalize it...
FWIW that's the test case: ```rust #[test] fn test_florp() { let dir = TempDir::new("globset_walkdir").expect("Failed to create temporary folder"); let dir_path = dir.path(); create_dir_all(dir_path.join("a/b/c")).expect(""); create_dir_all(dir_path.join("a/b/g")).expect(""); create_dir_all(dir_path.join("a/e/f")).expect(""); touch( &dir, &[ "a[/]b[/]c[/]lib.rs", "a[/]b[/]g[/]lib.rs",...