Giles Bathgate

Results 127 comments of Giles Bathgate

@kintel I helped make some fixes to CGAL in this area. Is it still related to throwing an exception from a destructor? (i.e while there is already an exception, and...

@kintel I don't think you can catch memory access issues. There must be somewhere that pl_ is not initialised. or a double delete?

I am not able to look at the code right now, but... When you make a copy, does it also copy pl_ or is it lazy initialised? Maybe the fix...

The problem appears to be in `External_structure_builder.h`, on line 128: ```c++ delete old_pl; SNC_external_structure C(*sncp,pl); C.clear_external_structure(); C.build_external_structure(); ``` This deletes the point locator, which then gets deleted again in the...

I think it could be fixed by simply re-ordering the operations: ```c++ SNC_external_structure C(*sncp,pl); C.clear_external_structure(); C.build_external_structure(); delete old_pl; ```

> Does it have a measurable impact? I was sure it did but now I cannot reproduce it.

@lrineau It didn't seem to make a significant performance impact. So I put it as a draft, thinking this would suppress progress.