Giedrius Statkevičius

Results 187 comments of Giedrius Statkevičius

I think this is a recurring issue for our users. Perhaps worth erroring out if retention is set to a small period with downsampling enabled? Because in such cases downsampling...

@yeya24 do you still want this merged?

That's an old version, there have been many, many fixes. Is it the same with the latest `main`?

What options do you have enabled? Have you tried `--writer.intern`?

:smile: it's https://github.com/storj/drpc. Fair point, I'm not arguing against that but I wonder what other libraries would fit the bill?

It is based on gRPC so I think that immediately disqualifies it because it has the same problems. Twirp also seems like it might be a valid option https://github.com/twitchtv/twirp. But...

vtprotobuf only provides the ability to use pooling on one side. I have noted that on the serialization side, it is completely unsafe to use pooling due to gRPC: https://github.com/planetscale/vtprotobuf/issues/20....

There's some recent movement though apparently https://github.com/grpc/grpc-go/issues/6619 so maybe this year this will be fixed in the Go gRPC implementation :smile: > This service demonstrated the benefit of this approach...

One more thing I want to do: build a dictionary from label names/values and use that for compression on an individual RPC level. Not possible with gRPC.

This could be nice to have. Currently, Thanos Query is unaware of the available resolutions. Data about available resolutions could be included in the metadata response.