Gerard Burns
Gerard Burns
@shogunpurple Ah nice one, oversight on my part. Thanks for pushing up the change.
Me and @deanhannigan talked about adding a binding that could be used by components to see whether they were currently in the builder or not. This could be used to...
@aptkingston Thanks for the in-depth review, I pushed up the changes you requested. Could you give this another look when you get a chance please?
@deanhannigan @aptkingston I've addressed both of your feedback if you could give this another look when you get a chance please. I updated the original PR message with more context...
@aptkingston I understand where you're coming from, but the implementation you suggested doesn't do the following (I think): - On hover link previews. - Right-click link menu (or force touch...
@deanhannigan Thanks a bunch for the thorough review, I've addressed or responded to everything, if you could give this another looks when you get a chance I'd appreciate it 🙏
@deanhannigan Had changed the colors of the modal before I think, but there was a redundant double declaration of the background colour in two different nested components, it's definitely `background-color:...
@aptkingston It was the latter, in the scenario I outlined in the main body of the PR a view could expose a value present in the base table that wasn't...
@adrinr Apologies for not having detailed reproduction steps in the original PR message, I hope this helps demonstrate the issue. Sorry for only getting around to this now: - use...
@shogunpurple Just waiting on some input from the backend folks on if I'm seeing ghosts or if this is a real issue, I'll move it to draft for now and...