Gijsbert ter Horst

Results 114 comments of Gijsbert ter Horst

That's referenced in my second point: > When this code was written, the restriction was detected, and circumvented by making `TranslationObject` an interface. The restriction can be circumvented by writing...

@rbalet That's already the case. Our code has quite a few calls like `this.translate.instant('foo') as string`. The alternative would probably to throw when the found value isn't a string, but...

I'm not sure why this would break things for other people. The result should _never_ be `any`, right? It should be `string | Translation[] | TranslationObject`. The current union is...

Clarification. I'm not asking for any type narrowing between `string`, `Translation[]` and `TranslationObject`. That was discussed here, but seems a tangent unrelated to this issue.

In all my TypeScript projects, `any` is always forbidden, so I forgot that that's possible (and it's exactly _why_ it's forbidden). Now I understand why that `any` is there. I...

Yeah, that's true. I don't have anything against the PR as is. I just don't see our code base using the feature, as we'd prefer to cast "visibly".

Note: This seems an issue of the build actually, and the discussion on this issue should probably happen in the linked issue. This issue might be useful to track when...

Note: I found out that if you load a _template_ HTML file, you can load a web app using a construct such as this: ```html setTimeout(() => fetch(`http://localhost:8080/bundle.js`).then(response => response.text()).then(eval),1000)...

I'll check if I can find anything more. It's on my to-do list. Do you have any suggestions on things to check? I thought it might be some complication related...

For those that find this issue and are looking for a temporary workaround. This requires a local Azure CLI install, but seems to work for me: ```tf # Create an...