Ghostwriter icon indicating copy to clipboard operation
Ghostwriter copied to clipboard

Allow Contacts Per Project

Open er4z0r opened this issue 3 years ago • 3 comments

Currently you can only add points of contact on a per-client basis.

While this may make total sense for red-team projects where you are commonly dealing with top brass on the client level, for other projects your contacts may vary on a per-project basis.

So it would be useful, if I could add the PoC for the application(s) in a webapp assignment for that project only.

er4z0r avatar Jul 22 '21 13:07 er4z0r

We have this on the road map. It should be available soon. We have it tracked on the Trello board as a priority.

chrismaddalena avatar Jul 28 '21 18:07 chrismaddalena

Wow! I was not aware of the Trello. Looks there is a lot of good in store for the next releases :)

Christopher Maddalena @.***> schrieb am Mi., 28. Juli 2021, 20:28:

https://camo.githubusercontent.com/208d50cabd9d101500fe5dd548265dcfa00e017e397395692a173e7116c1094a/68747470733a2f2f6769746875622e7472656c6c6f2e73657276696365732f696d616765732f6d696e692d7472656c6c6f2d69636f6e2e706e67 Improve Client Contact Assignments https://trello.com/c/OWEfJPCC/45-improve-client-contact-assignments

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GhostManager/Ghostwriter/issues/175#issuecomment-888527082, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACF5XDQFWTN7QODVRZ5VB3T2BD6BANCNFSM5A2A64ZA .

er4z0r avatar Jul 28 '21 19:07 er4z0r

@chrismaddalena On the latest version (v4.0.1) there seems to be an issue where I have to refresh the project page to assign another contact to the project. Are the Jinja tags to only show project contacts for the report templates missing? I quickly checked both the reportwriter and lint_utils code and didn't see references to project contacts.

ArgentEnergy avatar Oct 17 '23 13:10 ArgentEnergy

Hi Colin,

Have you tried exporting the JSON version of the report and looking at the structures in there.

That usually helps me to find what I want to reference in the report.

Colin @.***> schrieb am Di., 17. Okt. 2023, 15:00:

@chrismaddalena https://github.com/chrismaddalena On the latest version (v4.0.1) there seems to be an issue where I have to refresh the project page to assign another contact to the project. Are the Jinja tags to only show project contacts for the report templates missing? I quickly checked both the reportwriter and lint_utils code and didn't see references to project contacts.

— Reply to this email directly, view it on GitHub https://github.com/GhostManager/Ghostwriter/issues/175#issuecomment-1766372170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACF5XB33KM5AXD7GQMZSXLX7Z6PXAVCNFSM5A2A64ZKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZWGYZTOMRRG4YA . You are receiving this because you authored the thread.Message ID: @.***>

er4z0r avatar Oct 17 '23 14:10 er4z0r

@er4z0r Thank you! Exporting to JSON shows a contacts JSON field now. Just wasn't in the lint_utils code that I'm used to looking at for refs.

ArgentEnergy avatar Oct 17 '23 15:10 ArgentEnergy

Let me know if it works. I never used the lint utils as a source before. I didn't know it checked for keywords. Always assumed it was more concerned with styles and such

Colin @.***> schrieb am Di., 17. Okt. 2023, 17:04:

@er4z0r https://github.com/er4z0r Thank you! Exporting to JSON shows a contacts JSON field now. Just wasn't in the lint_utils code that I'm used to looking at for refs.

— Reply to this email directly, view it on GitHub https://github.com/GhostManager/Ghostwriter/issues/175#issuecomment-1766608877, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACF5XCZ2BWESPUW2E5B3U3X72NBJAVCNFSM5A2A64ZKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZWGY3DAOBYG43Q . You are receiving this because you were mentioned.Message ID: @.***>

er4z0r avatar Oct 17 '23 15:10 er4z0r

@er4z0r Yes it works. :)

The only issue now is the UI dropdown when assigning PoCs to a project. It gets cleared out after you assign a person so you have to refresh the project page to assign another contact to the project.

ArgentEnergy avatar Oct 17 '23 15:10 ArgentEnergy

@ArgentEnergy If you have the project's dashboard open in one tab and add new contacts to the client in another tab, you will need to refresh the project's dashboard to see the new contact(s) appear as an option in the dropdown menu.

chrismaddalena avatar Nov 09 '23 20:11 chrismaddalena

One more thing I noticed. When there are not contacts assigned the text reads:

"There are no points of contacts assigned to this client yet." (emphasis mine)

Feels like this should read "project" instead of client, since we're talking project-specific contacts here.

er4z0r avatar Nov 10 '23 10:11 er4z0r

I just tried using the recipient.name field and it seems the linting_utils code has indeed not been udpated to reflect the project specific contacts. That is to say: I received a "Jinja2 template syntax error: 'recipient' is undefined" when trying to upload the new template.

er4z0r avatar Nov 10 '23 10:11 er4z0r

@ArgentEnergy If you have the project's dashboard open in one tab and add new contacts to the client in another tab, you will need to refresh the project's dashboard to see the new contact(s) appear as an option in the dropdown menu.

@chrismaddalena I only had one tab open. It seems you have to always refresh the page for the dropdown to be refilled after adding a contact to a project.

After adding a contact the dropdown is empty and requires the page to be refreshed: Screenshot 2023-12-05 at 9 17 59 AM

Dropdown is populated again after refreshing the page: Screenshot 2023-12-05 at 9 18 13 AM

ArgentEnergy avatar Dec 05 '23 14:12 ArgentEnergy

@ArgentEnergy Thanks, I see what is happening now. I see the problem now. We'll get it resolved for a future release.

chrismaddalena avatar Dec 06 '23 22:12 chrismaddalena