Geyser icon indicating copy to clipboard operation
Geyser copied to clipboard

Start fixing our block breaking code

Open onebeastchris opened this issue 10 months ago • 3 comments

Once done, should fix https://github.com/GeyserMC/Geyser/issues/3627

To-do's:

  • [ ] tick block breaking -> prevent exceeding Java client limits
  • [ ] test item frame handling
  • [ ] custom tools can't break custom blocks
  • [ ] test whether block breaking needs to be confirmed preemptively

onebeastchris avatar Feb 19 '25 17:02 onebeastchris

This fix could be uploaded now to fix the problems with the blocks I've been testing it for the last few days and it seems to work fine. Only one spam is repeated in Console:

https://mclo.gs/7eqIkxv

Z3r0xh avatar Feb 22 '25 12:02 Z3r0xh

This PR isn't ready for testing yet, there are still some issues that need to be resolved

onebeastchris avatar Feb 22 '25 13:02 onebeastchris

How far are you with the pull-request?

Tjorven-Liebe avatar Apr 30 '25 12:04 Tjorven-Liebe

Will be superseded by a different PR - forcing Java-style block breaking in e.g. creative mode or even with almost-insta mining is unfortunately a pretty terrible user experience, so the approach here isn't suitable to be in main builds

onebeastchris avatar Aug 25 '25 13:08 onebeastchris