Geyser icon indicating copy to clipboard operation
Geyser copied to clipboard

hide tooltip item data component not working on geyser side

Open anthony114669 opened this issue 9 months ago • 12 comments

Describe the bug

hide item attributes not working on geyser side while on java are hiden correctly

To Reproduce

hide a attribute item on java, and check on bedrock,

Expected behaviour

reflec the hiden attributes on java items in bedrock

Screenshots / Videos

No response

Server Version and Plugins

No response

Geyser Dump

No response

Geyser Version

2.2.3-SNAPSHOT

Minecraft: Bedrock Edition Device/Version

No response

Additional Context

No response

anthony114669 avatar May 02 '24 19:05 anthony114669

does it work on the 1.20.5/.6 version (aka, now latest version) of Geyser? 1.20.5 changed item handling quite a lot, so it's possible it's also working on Geyser as well now

onebeastchris avatar May 02 '24 19:05 onebeastchris

does it work on the 1.20.5/.6 version (aka, now latest version) of Geyser? 1.20.5 changed item handling quite a lot, so it's possible it's also working on Geyser as well now

mmm i dunno, since im not usein minecraft 1.20.5 due plugin compatibilities, but thits problem it has been happening so long ago. i just report it rn but was happening on all versions before (since the 1.19.2) im belive

anthony114669 avatar May 02 '24 21:05 anthony114669

Please update to the latest Geyser version with ViaVersion, send a Geyser dump, and test if the issue is still present there. Thanks!

Camotoy avatar May 02 '24 21:05 Camotoy

Please update to the latest Geyser version with ViaVersion, send a Geyser dump, and test if the issue is still present there. Thanks!

ok for sure, i will do that for testing purpouses, in other hand i want to report other issue but i think i will create separate report, its about mobs attak animations they are not displaying it. thanks!

anthony114669 avatar May 02 '24 21:05 anthony114669

For mob attack animations, please verify and see if they exist on a singleplayer Bedrock world first.

Camotoy avatar May 02 '24 21:05 Camotoy

For mob attack animations, please verify and see if they exist on a singleplayer Bedrock world first.

ok i check already, and on single player the attack animatiosn works fine, its just on geyser where are not working, the mobs are like "static" when they attack, all hostile mobs

anthony114669 avatar May 02 '24 21:05 anthony114669

For mob attack animations, please verify and see if they exist on a singleplayer Bedrock world first.

hi! ok im already update viaversions plugins and im on geyser plugin lastest version and the item attributtes hiding feature still not working. so i guess is a bug

anthony114669 avatar May 03 '24 22:05 anthony114669

Please update to the latest Geyser version with ViaVersion, send a Geyser dump, and test if the issue is still present there. Thanks!

i did that and still not hiding the attributes on geyser side, here is the dump file:

https://dump.geysermc.org/HhQbQvxps0qxRqlcGZgbiUHzxljEmqNg

anthony114669 avatar May 04 '24 18:05 anthony114669

Unable to reproduce on a paper 1.20.6 server.

Reproduction steps i've used:

  • give myself an axe with attributes, once with the hide attributes flag:

/give @p iron_axe[attribute_modifiers={modifiers:[{type:"player.block_interaction_range",name:"player.block_interaction_range",amount:20,operation:"add_multiplied_total",uuid:[I;-1451731879,-342601818,-1938458044,532216741]},{type:"generic.armor",name:"generic.armor",amount:1,operation:"add_value",uuid:[I;2114322050,480790117,-1213153182,1728138811]}],show_in_tooltip:false}] 1

and once without: /give @p iron_axe[attribute_modifiers={modifiers:[{type:"player.block_interaction_range",name:"player.block_interaction_range",amount:20,operation:"add_multiplied_total",uuid:[I;-1451731879,-342601818,-1938458044,532216741]},{type:"generic.armor",name:"generic.armor",amount:1,operation:"add_value",uuid:[I;2114322050,480790117,-1213153182,1728138811]}]}] 1

image image

Seems to work as expected for me - please provide exact replication steps for how to reproduce the issue you're facing.

onebeastchris avatar May 06 '24 11:05 onebeastchris

Unable to reproduce on a paper 1.20.6 server.

Reproduction steps i've used:

  • give myself an axe with attributes, once with the hide attributes flag:

/give @p iron_axe[attribute_modifiers={modifiers:[{type:"player.block_interaction_range",name:"player.block_interaction_range",amount:20,operation:"add_multiplied_total",uuid:[I;-1451731879,-342601818,-1938458044,532216741]},{type:"generic.armor",name:"generic.armor",amount:1,operation:"add_value",uuid:[I;2114322050,480790117,-1213153182,1728138811]}],show_in_tooltip:false}] 1

and once without: /give @p iron_axe[attribute_modifiers={modifiers:[{type:"player.block_interaction_range",name:"player.block_interaction_range",amount:20,operation:"add_multiplied_total",uuid:[I;-1451731879,-342601818,-1938458044,532216741]},{type:"generic.armor",name:"generic.armor",amount:1,operation:"add_value",uuid:[I;2114322050,480790117,-1213153182,1728138811]}]}] 1

image image

Seems to work as expected for me - please provide exact replication steps for how to reproduce the issue you're facing.

hi! thanks for checking the issue.

mmm, well actually in that pucture (the one with attributes hided already) still shows the attribute to me, so thats is has is supouse to be?

because on java the item attribute hide at all, i mean just remain the item name, but on bedrock geyser the attribute still there, let me attach some example to show you..

Captura de pantalla 2024-05-06 184648

image

so as you can see, the sword attributes on java are totally hide, and on bedrock does not hide at all.

anthony114669 avatar May 06 '24 23:05 anthony114669

i forgot to tell you the command im using

/give Lord_Anthony1 iron_sword 1 {HideFlags:10}

this is the command to hide attributes i use

anthony114669 avatar May 06 '24 23:05 anthony114669

that command hides a lot more than just attributes :p but yeah, it seems like we currently do not translate that component properly

onebeastchris avatar May 07 '24 06:05 onebeastchris