Geyser icon indicating copy to clipboard operation
Geyser copied to clipboard

Published 20 hours ago • verified publisher icon GeyserMC

Patterns not appearing in loom

Open EldritchGarden opened this issue 2 years ago • 7 comments

Describe the bug

Banner shapes that have pattern items in Bedrock are not appearing in the loom menu for bedrock players.

To Reproduce

Open loom Attempt to use pattern shape, such as Bordure Indented

Expected behaviour

All shapes available in java should appear in loom menu

Screenshots / Videos

image

Server Version and Plugins

Server: Current: git-Purpur-1735 (MC: 1.19)* Velocity: 3.1.2-SNAPSHOT (git-6be344d9-b162)

Geyser Dump

https://dump.geysermc.org/wrHhV8zjvYZh7OkNtpdPCsuOJZ2upBsf

Geyser Version

Geyser version 2.0.6-SNAPSHOT (git-master-8f89647) (Java: 1.19.1, Bedrock: 1.19.0/1.19.2 - 1.19.10)

Minecraft: Bedrock Edition Device/Version

1.19.11, win10 & xbox

Additional Context

No response

EldritchGarden avatar Jul 28 '22 22:07 EldritchGarden

We don't have control of that portion of the UI, I can pretty confidently say. But aren't the pattern items unlocked when you use the pattern item? Otherwise, send a screenshot on Java and point out what's missing.

Camotoy avatar Jul 28 '22 22:07 Camotoy

There are 2 patterns in Bedrock that don't have items in Java, Field Masoned and Bordure Indented. Screenshot shows the Bordure Indented pattern in the loom in java without a pattern item.

image

EldritchGarden avatar Jul 28 '22 22:07 EldritchGarden

Yeah, I can't see any way we can resolve this.

Camotoy avatar Jul 28 '22 22:07 Camotoy

How does Geyser handle loom pattern selection events? I can override pattern selection on the server side with an event listener, but it doesnt work for bedrock players.

EldritchGarden avatar Jul 29 '22 16:07 EldritchGarden

As with a lot of things, I do believe this is client-sided which means we don't have control

Chew avatar Jul 30 '22 23:07 Chew

Because of the way Bedrock works, we send the pattern selection, and then immediately send us clicking on the inventory slot.

Camotoy avatar Jul 30 '22 23:07 Camotoy

I'm certainly not an authority on plugin development, but I don't think anything can be done on the server side either. It should be possible with a Geyser extension, but that's not something I care to attempt until extension support is included in the main release.

EldritchGarden avatar Jul 31 '22 21:07 EldritchGarden

Is there anyway to do the reverse and give java players/ server the item to make Bordure Indented pattern

Stuart-Cox avatar Sep 15 '23 18:09 Stuart-Cox

Not really, no. Even if there was a way, it would be outside the scope of Geyser - Geyser does not modify Java server behavior.

onebeastchris avatar Sep 15 '23 22:09 onebeastchris