Floodgate icon indicating copy to clipboard operation
Floodgate copied to clipboard

Excessive session server lookups (velocity & potential other platforms)

Open bridgelol opened this issue 1 month ago • 1 comments

Floodgate currently forwards a "broken" gameprofile to velocity that does not contain any properties at all, causing paper instances to register this player as not having any textures and therefor fetching mojang's authservers which causes (invalid) api calls every time a bedrock player switches a server on velocity.

I've recently contributed a patch to paper to prevent them from looking up profiles when it's not needed: https://github.com/PaperMC/Paper/commit/21d91ce634481f58a8e94f6c02651dbaaeb4408f

After closely monitoring this and building my own system around it I noticed this only happens to bedrock players so I dug deeper and found out this a fundamental flaw within floodgate.

Even default minecraft java accounts that have never selected a skin still have the "textures" property in their gameprofile, either Steve or Alex. I suggest floodgate applies either one of these by default, will be pushing a PR for this, however would like some more feedback on this.

Steve: eyJ0aW1lc3RhbXAiOjE1MzIwOTIwMDAsInByb2ZpbGVJZCI6InBsYXllci11dWlkIiwicHJvZmlsZU5hbWUiOiJwbGF5ZXItbmFtZSIsInRleHR1cmVzIjp7IkZJTkFMIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYjgyN2ViZmY3ZjJlZDVjM2I5ZTdiYzZhNTE5NjkzNjdmMzljYjMwZjk3YTc0NjViOWU5OGZkNDY5NGZmODAwZiJ9fX19

Alex: eyJ0aW1lc3RhbXAiOjE1MzIwOTIwMDAsInByb2ZpbGVJZCI6InBsYXllci11dWlkIiwicHJvZmlsZU5hbWUiOiJwbGF5ZXItbmFtZSIsInRleHR1cmVzIjp7IkZJTkFMIjp7InVybCI6Imh0dHA6Ly90ZXh0dXJlcy5taW5lY3JhZnQubmV0L3RleHR1cmUvYTkxMjFkMjZjNzU2NzA2YzY3MTcyZjM3YzYxNzFlZDk4NmE2NDgzODc5MjlhODc0MDQ1OGY0MTE2YjYxIn19fQ==

bridgelol avatar May 10 '24 00:05 bridgelol