Floodgate icon indicating copy to clipboard operation
Floodgate copied to clipboard

Option to disable Bedrock Skins

Open Kruize1 opened this issue 2 years ago • 9 comments

I mainly ask for this option as a way to possibly improve performance.

Geyser + Floodgate seem to take up about 1 Gig of RAM, but I think maybe disabling bedrock skins will allow for slightly better performance, as they wont need to connect to the Skin Uploader?

Kruize1 avatar Aug 14 '21 01:08 Kruize1

While that is a fine request, we'd rather just decrease the memory consumption (or at least find out what's really taking up all that RAM instead of guessing). Are you able to send over a heap dump instead? https://www.baeldung.com/java-heap-dump-capture

Camotoy avatar Aug 14 '21 01:08 Camotoy

I can send the heap dump, but would attaching it here be okay and the preferred method? Or how should I send it to you?

Kruize1 avatar Aug 14 '21 01:08 Kruize1

If you are able, you are free to send it here.

Camotoy avatar Aug 14 '21 01:08 Camotoy

It doesn't seem to work, can I send the file to you via Discord?

Kruize1 avatar Aug 14 '21 01:08 Kruize1

Yes.

Camotoy avatar Aug 14 '21 01:08 Camotoy

Honestly it seems like Dynmap is the biggest plugin affecting your RAM. Try removing that?

Camotoy avatar Aug 14 '21 03:08 Camotoy

I already disabled Dynmap, but I still had memory issues unfortunately.

When I start my server without Geyser + Floodgate my memory usage starting out is around 2.7/4 Gigs

However, I just tried with both enabled and RAM usage starts fairly high: image

Is 1 Gig of memory usage the expected amount? Or what should the memory usage roughly be?

Kruize1 avatar Aug 14 '21 03:08 Kruize1

If this is purely for improving performance then I think that closing this issue is the best thing to do as it barely affects performance / ram usage. If you're seriously interested in having an option to disable this because you don't want anyone to see (converted) Bedrock skins, I'll keep it open until we've looked into adding more config options.

Tim203 avatar Sep 04 '21 20:09 Tim203

Yes, I would like to have that option.

Kruize1 avatar Sep 08 '21 00:09 Kruize1