Beans icon indicating copy to clipboard operation
Beans copied to clipboard

Prevented output of empty skip link markup.

Open christophherr opened this issue 7 years ago • 2 comments

closes #336.

christophherr avatar Sep 26 '18 23:09 christophherr

Should there be tests added to check for this behaviour?

ibes avatar Sep 27 '18 00:09 ibes

Arguably, keeping the (array) would prevent beans_output_skip_links from ever fataling. The downside is that if you want to shortcircuit the skip links with the filter, you can only use __return_null. Without the casting, you can use __return_false or __return_null in the filter.

I've no strong preference either way.

Yes, tests should be added to beansBuildSkipLinks.php and a few new tests written for beans_output_skip_links

christophherr avatar Sep 27 '18 00:09 christophherr