webrtc-android icon indicating copy to clipboard operation
webrtc-android copied to clipboard

Published 20 hours ago • verified publisher icon GetStream

update file ScreenCapturerAndroid.java from official commit https://w…

Open gongluck opened this issue 1 year ago • 4 comments

update file ScreenCapturerAndroid.java from official commit

this can slove #82

gongluck avatar Nov 07 '24 09:11 gongluck

Thanks @gongluck for contributing to this project! @kanat will review this PR soon.

skydoves avatar Nov 21 '24 01:11 skydoves

Thanks @gongluck for contributing to this project! @kanat will review this PR soon.

Thank you for the recognition. I'm eager to hear @kanat's thoughts on the changes.

gongluck avatar Nov 21 '24 02:11 gongluck

Hi @gongluck,

Thank you for the contribution ❤️

Would you mind moving this fix to our main WebRTC repo:

  • https://github.com/GetStream/webrtc/blob/main/sdk/android/api/org/webrtc/ScreenCapturerAndroid.java

Cheers!

kanat avatar Nov 29 '24 14:11 kanat

Hi @gongluck,

Thank you for the contribution ❤️

Would you mind moving this fix to our main WebRTC repo:

  • https://github.com/GetStream/webrtc/blob/main/sdk/android/api/org/webrtc/ScreenCapturerAndroid.java

Cheers!

Oh, I didn't notice. GetStream's main webrtc repository has updated the ScreenCapturerAndroid source file, so it should be fine. But the current webrtc-android repository is not updated together?

gongluck avatar Nov 29 '24 15:11 gongluck