stream-laravel icon indicating copy to clipboard operation
stream-laravel copied to clipboard

Package broken?

Open Roywcm opened this issue 4 years ago • 4 comments

After the latest update, I can't manage to retrieve the feeds? I get feed_slug can only contain alphanumeric characters or underscores on the notification feed and Invalid argument supplied for foreach() on the timeline feed.

I checked and it looks like the config setting key's in StreamLaravelManager.php are not right anymore?

Roywcm avatar May 27 '20 17:05 Roywcm

Having the same issue. Seems like StreamLaravelManager is trying to access notifications_feed by using the invalid syntax:

$user_feed = $this->config->get("stream-laravel::notification_feed");

I think it should use "dot" notation instead: stream-laravel.notification_feed

petrokarpiuk avatar Jun 10 '20 13:06 petrokarpiuk

Created PR - #89

petrokarpiuk avatar Jun 10 '20 13:06 petrokarpiuk

Got the same bug, wonder which version caused this

imam avatar Jun 21 '20 09:06 imam

So this caused on 2.3.7, I believe the bug made on this commit https://github.com/GetStream/stream-laravel/commit/0379873b513b81631225eb3bf313f569f84a03df . So... Maybe suggestion for next GetStream updates, please if you want to update something that might broke the current release, update it on the next minor version (v2.4.0), as v2.3.7 should reserve for bug update, pretty dissappointed as it break my site and finding the bug is not easy

imam avatar Jun 21 '20 09:06 imam