stream-chat-swift icon indicating copy to clipboard operation
stream-chat-swift copied to clipboard

[Reactions v2] New reactions query endpoint

Open nuno-vieira opened this issue 10 months ago β€’ 3 comments

πŸ”— Issue Links

Resolves https://github.com/GetStream/ios-issues-tracking/issues/787

🎯 Goal

Adds the new reactions v2 query endpoint to be able to filter reactions based on type and author.

πŸ“ Summary

  • Adds new ChatReactionListController
  • Adds new Slack Reactions List View to the Slack Example app

πŸ›  Implementation

Creates a new ChatReactionListController to follow the SDK pattern, where each query endpoint represents a controller.

TODO:

  • [ ] Everything is tested besides the ReactionListController.
  • [ ] Website docs for the new reaction list controller

🎨 Showcase

https://github.com/GetStream/stream-chat-swift/assets/12814114/42954fea-95ac-45cf-8046-0291d94e1d9d

πŸ§ͺ Manual Testing Notes

Note: Backend user enrichment is not working on the new query reactions endpoint. So this is not testable until it is fixed on the backend.

  1. Open the Slack Example App
  2. Go to a channel
  3. Long press on a reaction
  4. It should show only the reactions of that type.

β˜‘οΈ Contributor Checklist

  • [x] I have signed the Stream CLA (required)
  • [x] This change follows zero ⚠️ policy (required)
  • [x] This change should be manually QAed
  • [x] Changelog is updated with client-facing changes
  • [ ] New code is covered by unit tests
  • [ ] Comparison screenshots added for visual changes
  • [ ] Affected documentation updated (docusaurus, tutorial, CMS)

nuno-vieira avatar Apr 24 '24 17:04 nuno-vieira

1 Warning
:warning: Big PR

Generated by :no_entry_sign: Danger

github-actions[bot] avatar Apr 24 '24 17:04 github-actions[bot]

StreamChat XCMetrics

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 2.5 ms 75.0% πŸ”Ό 🟒
Duration 2.6 s 2.55 s 1.92% πŸ”Ό 🟒
Hitch time ratio 4 ms per s 0.99 ms per s 75.25% πŸ”Ό 🟒
Frame rate 79 fps 78.39 fps 0.77% πŸ”Ό 🟒
Number of hitches 1 0.2 80.0% πŸ”Ό 🟒
ChannelList Hitches total duration 12.5 ms 16.69 ms -33.52% πŸ”½ πŸ”΄
Duration 2.6 s 0.82 s 68.46% πŸ”Ό 🟒
Hitch time ratio 5 ms per s 20.51 ms per s -310.2% πŸ”½ πŸ”΄
Frame rate 76 fps 63.2 fps 16.84% πŸ”Ό 🟒
Number of hitches 1.2 0.8 33.33% πŸ”Ό 🟒

Stream-SDK-Bot avatar Apr 26 '24 21:04 Stream-SDK-Bot