stream-chat-swift
stream-chat-swift copied to clipboard
[Reactions v2] New reactions query endpoint
π Issue Links
Resolves https://github.com/GetStream/ios-issues-tracking/issues/787
π― Goal
Adds the new reactions v2 query endpoint to be able to filter reactions based on type and author.
π Summary
- Adds new
ChatReactionListController
- Adds new Slack Reactions List View to the Slack Example app
π Implementation
Creates a new ChatReactionListController
to follow the SDK pattern, where each query endpoint represents a controller.
TODO:
- [ ] Everything is tested besides the
ReactionListController
. - [ ] Website docs for the new reaction list controller
π¨ Showcase
https://github.com/GetStream/stream-chat-swift/assets/12814114/42954fea-95ac-45cf-8046-0291d94e1d9d
π§ͺ Manual Testing Notes
Note: Backend user enrichment is not working on the new query reactions endpoint. So this is not testable until it is fixed on the backend.
- Open the Slack Example App
- Go to a channel
- Long press on a reaction
- It should show only the reactions of that type.
βοΈ Contributor Checklist
- [x] I have signed the Stream CLA (required)
- [x] This change follows zero β οΈ policy (required)
- [x] This change should be manually QAed
- [x] Changelog is updated with client-facing changes
- [ ] New code is covered by unit tests
- [ ] Comparison screenshots added for visual changes
- [ ] Affected documentation updated (docusaurus, tutorial, CMS)
StreamChat XCMetrics
target |
metric |
benchmark |
branch |
performance |
status |
---|---|---|---|---|---|
MessageList | Hitches total duration | 10 ms | 2.5 ms | 75.0% πΌ | π’ |
Duration | 2.6 s | 2.55 s | 1.92% πΌ | π’ | |
Hitch time ratio | 4 ms per s | 0.99 ms per s | 75.25% πΌ | π’ | |
Frame rate | 79 fps | 78.39 fps | 0.77% πΌ | π’ | |
Number of hitches | 1 | 0.2 | 80.0% πΌ | π’ | |
ChannelList | Hitches total duration | 12.5 ms | 16.69 ms | -33.52% π½ | π΄ |
Duration | 2.6 s | 0.82 s | 68.46% πΌ | π’ | |
Hitch time ratio | 5 ms per s | 20.51 ms per s | -310.2% π½ | π΄ | |
Frame rate | 76 fps | 63.2 fps | 16.84% πΌ | π’ | |
Number of hitches | 1.2 | 0.8 | 33.33% πΌ | π’ |
Quality Gate passed
Issues
64 New issues
0 Accepted issues
Measures
0 Security Hotspots
82.5% Coverage on New Code
0.0% Duplication on New Code